Improve logging by separating debug from information

[shyba]

fDebug flag can be used for that like:

lbrycrd/src/main.cpp

Lines 5226 to 5227 in 01a222a

	if (fDebug || (vInv.size() != 1))
	LogPrint("net", "received getdata (%u invsz) peer=%d\n", vInv.size(), pfrom->id);

It's initialized according to -debug setting:

lbrycrd/src/init.cpp

Line 860 in 270307a

fDebug = !mapMultiArgs["-debug"].empty();

Ideally it should be applied to log messages that doesn't hold information for a sysadmin, but mainly for developers, like: https://github.com/lbryio/lbrycrd/blob/master/src/claimtrie.cpp#L1927

To be updated with more examples where it should be applied after #137 gets merged as it adds more cases.

[alyssaoc]

@shyba Is this still a valid issue

[BrannonKing]

I didn't mean to close this. I think it's a valid issue. I think it could be a subset of the work on issue #211

[BrannonKing]

@lbrynaut reports that repeatedly calling "generate 1" significantly increases the log size. This appears to just be the standard logging for every new block -- log new claims, supports, etc. I think we should revisit that logging as part of this issue. Maybe by default we just summarize each new block, and maybe we don't bother to summarize those that we generate locally.

[BrannonKing]

I think is sufficiently covered with the move of the claim logging into its own category.

[ghost]

I want free swag t-shirt. Fake crying