Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endless loop video playback error #110

Merged
merged 2 commits into from Nov 6, 2019

Conversation

@sayplastic
Copy link
Member

sayplastic commented Nov 1, 2019

This fixes an off-by-one video playback error which caused endless blob download loop for small streams.

@sayplastic sayplastic requested a review from nikooo777 Nov 1, 2019
@lbry-bot lbry-bot assigned nikooo777 and unassigned sayplastic Nov 1, 2019
@sayplastic sayplastic requested a review from tiger5226 Nov 1, 2019
Copy link
Member

nikooo777 left a comment

looks a lot like magic to me but if it works, it works!

startOffsetInBlob = 0
}
readLen := 0
// if n > 0 {

This comment has been minimized.

Copy link
@nikooo777

nikooo777 Nov 4, 2019

Member

cleanup needed?

This comment has been minimized.

Copy link
@sayplastic

sayplastic Nov 6, 2019

Author Member

Yep, sorry about that!

@sayplastic sayplastic merged commit 9fed70b into master Nov 6, 2019
2 checks passed
2 checks passed
ci/circleci: test Your tests passed on CircleCI!
Details
coverage/coveralls Coverage increased (+0.1%) to 64.628%
Details
@sayplastic sayplastic deleted the bugfix/video_loop branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.