Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use offline host lists #12

Merged
3 commits merged into from Feb 28, 2016

Conversation

Projects
None yet
1 participant
@alfateam123
Copy link
Contributor

alfateam123 commented Feb 28, 2016

This PR adds the ability to use an offline list to retrieve the host list.
This addition is useful when you want to use a different set of hosts, or to manually manage the list.

Two new switches are proposed:

  • -j /path/to/host_list.json to tell limf to use an offline list
  • -s to show the host list. Nothing will be uploaded, encrypted or decrypted when this switch is active.

This behavior is changed:

  • The list of the hosts is not available when executing limf -h: we have two possible sources (offline or online), but we can't be sure which one we should pick. It's available with -s.

This behavior is not changed:

  • Online list is still the default: just don't use -j switch.

Couldn't you just download the repository, change the URL of the online list and install?
It's be an interesting idea, but I don't want to download the list, at all.


By the way, thank you for limf: it's useful and very easy to use.

alfateam123 added some commits Feb 28, 2016

Add ability to use local host list
add limf/hostlist.py: it only contains host list manipulation
functions.

add `-j <local host list file>` switch to select local list.
If `-j` is not used, the online list will be retrieved.
Remove initial host list retrieval
Remove initial host list retrieval from github or local resource,
so we won't have to guess where is the host list
we have to show in `-c` help string.

Refactor host number check, help string.
Add -s to list the available hosts
This option still needs the positional, required `file` argument.
The execution will stop before uploading things though.
@ghost

This comment has been minimized.

Copy link

ghost commented Feb 28, 2016

I wasn't expecting that. When I made limf, I thought of it as something for myself, and the only contributions will be additions to host_list.json.
Huge thanks, and I'm merging that pull request, and I will just have to update the PIP version, so other can enjoy the changes.

ghost pushed a commit that referenced this pull request Feb 28, 2016

@ghost ghost merged commit 4bcf74b into lc-guy:master Feb 28, 2016

@ghost

This comment has been minimized.

Copy link

ghost commented Feb 28, 2016

I had to update it as -s did not worked without file arguments. Now pip install limf --upgrade should get newest working version.
Still, thanks for contribution.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.