Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to `utf8` for LCache tables #149

Merged
merged 2 commits into from Oct 3, 2017
Merged

Switch back to `utf8` for LCache tables #149

merged 2 commits into from Oct 3, 2017

Conversation

@danielbachhuber
Copy link
Member

danielbachhuber commented Sep 29, 2017

Because our value column is longtext, utf8mb4 isn't necessary for
storing unicode characters.

See #148

Because our `value` column is `longtext`, `utf8mb4` isn't necessary for
storing unicode characters.
@davidstrauss

This comment has been minimized.

Copy link
Member

davidstrauss commented Sep 30, 2017

This sounds reasonable to me, though I'm not sure of the benefit if there aren't any indexes on the value column.

@danielbachhuber

This comment has been minimized.

Copy link
Member Author

danielbachhuber commented Oct 3, 2017

though I'm not sure of the benefit if there aren't any indexes on the value column.

The value column was the original motivation for utf8mb4, but the change also applied to the address column (which is included in an index).

@danielbachhuber danielbachhuber merged commit bd35672 into master Oct 3, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
@danielbachhuber danielbachhuber deleted the 148-utf8 branch Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.