From 1a9b26c05f778928b04af59b6d75d3a0a98669ef Mon Sep 17 00:00:00 2001
From: Grzegorz Sadowski <sadowskigp@gmail.com>
Date: Fri, 13 Mar 2020 12:50:13 +0100
Subject: [PATCH] [API] CS fixes in configuration of serializer

---
 .../config/api_resources/ProductOption.xml    |  2 +-
 .../Resources/config/serializer/Customer.xml  | 15 +++++++++--
 .../config/serializer/CustomerGroup.xml       | 15 +++++++++--
 .../config/serializer/ExchangeRate.xml        | 15 +++++++++--
 .../Resources/config/serializer/Order.xml     | 15 +++++++++--
 .../Resources/config/serializer/Payment.xml   | 15 +++++++++--
 .../config/serializer/PaymentMethod.xml       | 15 +++++++++--
 .../Resources/config/serializer/Product.xml   | 15 +++++++++--
 .../config/serializer/ProductOption.xml       | 16 +++++++++---
 .../serializer/ProductOptionTranslation.xml   | 16 +++++++++---
 .../config/serializer/ProductOptionValue.xml  | 16 +++++++++---
 .../ProductOptionValueTranslation.xml         | 16 +++++++++---
 .../config/serializer/ProductReview.xml       | 25 +++++++++++++------
 .../config/serializer/ShippingCategory.xml    | 15 +++++++++--
 .../config/serializer/TaxCategory.xml         | 21 ++++++++++++----
 15 files changed, 191 insertions(+), 41 deletions(-)

diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ProductOption.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ProductOption.xml
index f8d24e307d9..d1dda51c2af 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ProductOption.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/ProductOption.xml
@@ -51,7 +51,7 @@
         <property name="createdAt" writable="false" />
         <property name="updatedAt" writable="false" />
         <property name="values" readable="true" writable="true">
-            <subresource resourceClass="%sylius.model.product_option_value.class%" collection="true" />
+            <subresource resourceClass="Sylius\Component\Product\Model\ProductOptionValue" collection="true" />
         </property>
         <property name="translations" readable="true" writable="true" />
     </resource>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Customer.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Customer.xml
index 78612cb5b60..753cf8d8c09 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Customer.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Customer.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Core\Model\Customer">
         <attribute name="id">
             <group>customer:read</group>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/CustomerGroup.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/CustomerGroup.xml
index 0c1045ca8a9..d1d7c39b4a7 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/CustomerGroup.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/CustomerGroup.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Customer\Model\CustomerGroup">
         <attribute name="id">
             <group>customer_group:read</group>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ExchangeRate.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ExchangeRate.xml
index ddc62ef6207..2eadd0176b5 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ExchangeRate.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ExchangeRate.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Currency\Model\ExchangeRate">
         <attribute name="id">
             <group>exchange_rate:read</group>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Order.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Order.xml
index 4bc3e5ca7ba..eff0ff13737 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Order.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Order.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Core\Model\Order">
         <attribute name="id">
             <group>order:read</group>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Payment.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Payment.xml
index e2441438c30..f2acd232075 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Payment.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Payment.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Core\Model\Payment">
         <attribute name="id">
             <group>payment:read</group>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/PaymentMethod.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/PaymentMethod.xml
index b5b1c42fc40..01e00151610 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/PaymentMethod.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/PaymentMethod.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Core\Model\PaymentMethod">
         <attribute name="id">
             <group>payment_method:read</group>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Product.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Product.xml
index 0a799d1e127..136c2d413e1 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Product.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/Product.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Core\Model\Product">
         <attribute name="id">
             <group>product:read</group>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOption.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOption.xml
index 15b4b5453cc..84f1b7c58d5 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOption.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOption.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Product\Model\ProductOption">
         <attribute name="id">
             <group>product_option:read</group>
@@ -32,5 +43,4 @@
             <group>product_option:update</group>
         </attribute>
     </class>
-
 </serializer>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionTranslation.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionTranslation.xml
index 0f1c11e7aa4..ac1ec3aaf58 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionTranslation.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionTranslation.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Product\Model\ProductOptionTranslation">
         <attribute name="id">
             <group>product_option:read</group>
@@ -18,5 +29,4 @@
             <group>product_option:update</group>
         </attribute>
     </class>
-
 </serializer>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionValue.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionValue.xml
index 15659d9fbf9..92658c76181 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionValue.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionValue.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Product\Model\ProductOptionValue">
         <attribute name="id">
             <group>product_option_value:read</group>
@@ -21,5 +32,4 @@
             <group>product_option_value:write</group>
         </attribute>
     </class>
-
 </serializer>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionValueTranslation.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionValueTranslation.xml
index bf5dce1fa92..9d33f6b0595 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionValueTranslation.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductOptionValueTranslation.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Product\Model\ProductOptionValueTranslation">
         <attribute name="id">
             <group>product_option_value:read</group>
@@ -20,5 +31,4 @@
             <group>product_option_value:write</group>
         </attribute>
     </class>
-
 </serializer>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductReview.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductReview.xml
index 12d221d7735..15062808c44 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductReview.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ProductReview.xml
@@ -1,17 +1,28 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Core\Model\ProductReview">
-       <attribute name="createdAt">
-           <group>product_review:read</group>
-       </attribute>
-       <attribute name="updatedAt">
+        <attribute name="id">
+            <group>product_review:read</group>
+        </attribute>
+        <attribute name="createdAt">
            <group>product_review:read</group>
        </attribute>
-       <attribute name="id">
+        <attribute name="updatedAt">
            <group>product_review:read</group>
        </attribute>
        <attribute name="title">
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ShippingCategory.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ShippingCategory.xml
index 319e757b8ba..1d0a4cbc8a8 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ShippingCategory.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/ShippingCategory.xml
@@ -1,9 +1,20 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Shipping\Model\ShippingCategory">
         <attribute name="id">
             <group>shipping_category:read</group>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/TaxCategory.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/TaxCategory.xml
index 52348cebabd..e294e66098c 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/TaxCategory.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serializer/TaxCategory.xml
@@ -1,17 +1,28 @@
 <?xml version="1.0" ?>
 
+<!--
+
+ This file is part of the Sylius package.
+
+ (c) Paweł Jędrzejewski
+
+ For the full copyright and license information, please view the LICENSE
+ file that was distributed with this source code.
+
+-->
+
 <serializer xmlns="http://symfony.com/schema/dic/serializer-mapping"
             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd">
-
+            xsi:schemaLocation="http://symfony.com/schema/dic/serializer-mapping https://symfony.com/schema/dic/serializer-mapping/serializer-mapping-1.0.xsd"
+>
     <class name="Sylius\Component\Taxation\Model\TaxCategory">
-        <attribute name="createdAt">
+        <attribute name="id">
             <group>tax_category:read</group>
         </attribute>
-        <attribute name="updatedAt">
+        <attribute name="createdAt">
             <group>tax_category:read</group>
         </attribute>
-        <attribute name="id">
+        <attribute name="updatedAt">
             <group>tax_category:read</group>
         </attribute>
         <attribute name="code">