Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct class name for in-memory keys in documentation #632

Merged
merged 1 commit into from Jan 28, 2021

Conversation

@lots0logs
Copy link
Contributor

@lots0logs lots0logs commented Jan 15, 2021

Update configuration docs to match current code implementation.

Copy link
Owner

@lcobucci lcobucci left a comment

Thanks @lots0logs!

Just a small detail, we should also change this in v4.0.x branch (I'll apply the change and rebase things)

Loading

@@ -81,9 +81,11 @@ use Lcobucci\JWT\Signer;
use Lcobucci\JWT\Signer\Key\LocalFileReference;
use Lcobucci\JWT\Signer\Key\InMemory;
// You may use RSA OR ECDSA and all their variations (256, 384, and 512) and EdDSA over Curve25519
$signer = new Signer\Rsa\Sha512();
$signer = Signer\Ecdsa\Sha512::create();
Copy link
Owner

@lcobucci lcobucci Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use an alert to convey this difference (instead of re-assigning the variable).

Loading

@lcobucci lcobucci self-assigned this Jan 28, 2021
@lcobucci lcobucci added this to the 4.0.1 milestone Jan 28, 2021
@lcobucci lcobucci changed the base branch from 4.1.x to 4.0.x Jan 28, 2021
@lcobucci lcobucci changed the title Update configuration.md Use the correct class name for in-memory keys in documentation Jan 28, 2021
@lcobucci lcobucci merged commit b80c487 into lcobucci:4.0.x Jan 28, 2021
12 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants