Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Try llvm_readcyclecounter for Rand48.defaultSeed on ARM, x86 linux, SPARC, RISC-V, non-OSX PPC #168

Closed
wants to merge 1 commit into from

Conversation

n8sh
Copy link

@n8sh n8sh commented Nov 17, 2019

RISC-V support for llvm_readcyclecounter was added in LLVM 9.

…PARC, RISC-V, non-OSX PPC

RISC-V support for llvm_readcyclecounter was added in LLVM 9.
@kinke
Copy link
Member

kinke commented Nov 18, 2019

May I ask how you found this? After a quick glance, it seems it's called exactly twice in the lifetime of a process, when initializing the GC (and its 2 treaps, and Treap being the only Rand48 user).

@n8sh
Copy link
Author

n8sh commented Nov 19, 2019

I don't remember the context but I might have originally come across it while searching for uses of time. If it's only used twice per process, maybe it would be better to instead submit an upstream patch that removes defaultSeed and uses a pair of constants when initializing the treaps.

@kinke
Copy link
Member

kinke commented Nov 19, 2019

Yep that's what I was thinking as well; I doubt these non-deterministic GC treaps are desirable. Pinging @rainers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants