[2.067] MSVCRT 14 (VS 2015) support #29
Conversation
| va_list args; | ||
| va_start(args, format); | ||
| return vscanf(format, args); | ||
| } |
There was a problem hiding this comment.
For what porpose all that functiions are added ?
One can use legacy_stdio_definitions library for those functions.
There was a problem hiding this comment.
I didn't know about that lib. Can you confirm just linking to that lib and omitting these new wrappers works (allowing you to build the druntime and phobos test runners)?
There was a problem hiding this comment.
Yes, i can. I'd built ldc with msvc 2015. Only thing i'd changed is new way fo acquiring std(in|out|err) with __acrt_iob_func and also i'd removed _f(put|get)c_nolock because they're already implemented in new msvc runtime.
There was a problem hiding this comment.
Thanks, I've confirmed it too and changed the commit accordingly.
I actually went through the D file and compared it against the VS 2015 C header, so this PR fixes more issues than those you mentioned.
|
Nice that we'll finally get something resembling a conforming C99 implementation (it also fixes a couple of annoying C++11 bugs, but of course that's hardly relevant for us). Imho, it would even make sense to focus our efforts on Visual Studio 2015 for now. Once this is stable, we can always go back and add in workarounds for the older versions. |
|
How far away are we from reviewing/merging this, considering VS2015 is out the door? |
|
I'd be okay with simply uncommenting the line declaring version |
|
The 3rd commit makes VS 2015 the default target for MSVC builds. No objections wrt. merging from my side. ;) |
kinke
changed the title
|
Wouldn't it be better to let the compiler detect the VC version and provide the version declaration? |
|
That's an option and would be another reasonable use case for integer versions ( |
|
Also see dlang#1341. |
|
Closing this in favor of #32, a direct cherry-pick of dlang#1341, which just got merged upstream. |
MS mainly focused on
stdio.hin their upcoming C runtime. It provides important C99 fixes, see http://blogs.msdn.com/b/vcblog/archive/2014/06/18/crt-features-fixes-and-breaking-changes-in-visual-studio-14-ctp1.aspx. E.g., it fixes ldc-developers/ldc#761 with no additional changes.