-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since 0.16.0, can't build any project with DUB whenever it has a dependency #1061
Comments
|
Same problem on Windows. Maybe the problem is the discrepancy between output files: |
|
I can confirm this. The difference to previous versions is that for libraries, |
|
It is not an intentional change. We should match DMD's behavior here. Anybody care to submit a PR? |
Starting with LLVM 3.7, linkage and COMDAT are 2 different concepts. This means that LinkageODROnce does not put the object into a COMDAT. On Windows this resulted in linker error messages. This PR places all template functions, TypeInfo objects and other objects into a COMDAT.
An attempt to fix a test case results in breaking compiling with dub. This PR reverts part of the former fix. The changed test case is missing.
|
Fixed in merge-2.067 branch. |
|
Something is not quite right yet (0.160.0 alpha3). When compiling current vibe.d with The build command-line starts with (only possibly relevant args): I believe this file is supposed to end up in |
|
This file (which is linked from the release page) doesn't contain the change: driver/linker.cpp:456 is not commented out. |
|
@redstar: Ping. What happened here? This is pretty critical. |
|
I am checking it... |
|
Please reopen this! I can't compile a Gtk-D based project using LDC, even though it compiles happily with DMD: |
|
@testing-in-chrome: Please open a new issue with all the relevant details (operating system/compiler/dub versions, etc.). This has been closed for almost two years, and if you are using the latest version of LDC, you are likely seeing a different issue. |
|
I believe that this was something fixed quite a while ago (I think it was around 1.1.0). As a matter of fact, I was not able to reproduce your error with dub 1.4.0 and ldc 1.3.0. |
This seriously limits the ability to find more bugs since none of my projects build.
For an example, try to build d-idioms:
What changed? It used to work with 0.15.x
(BTW I maintain the DUB PR that allows to use
--compiler=ldc2on Mac: dlang/dub#638It would be merged more easily if LDC accepted multiple
-marchflags like DMD (yes, DUB sends many -march flags for some reason)).OS: Mac OS X
The text was updated successfully, but these errors were encountered: