Cannot compile two files with same name (in different dirs)

[thewilsonator]

the write objects as fully qualified has stopped after a rebase from july to trunk.

tested with
source/
a/File.d
b/File.d
with flags in the dub.json set to "dflags" : ["-oq"]

running with dub build --compiler=/path/to/ldc2 -v
gives

Running ../ldcbuild/bin/ldc2...
../ldcbuild/bin/ldc2 -oq -of.dub/build/application-debug-posix.osx-x86_64-ldc_0-1F6812A58C8D17B1F6048EEE6633F2C7/oqtest -d-debug -g -w -oq -od=.dub/obj -d-version=Have_oqtest -Isource/ source/B/File.d source/a/File.d source/app.d

Error: module File from file source/a/File.d conflicts with another module File from file source/B/File.d
(dub errors)```

[JohanEngelen]

@thewilsonator Can you git bisect to find the commit that broke things?

[thewilsonator]

maybe, i'll have a go.

[kinke]

Not necessary, it's most likely one of my recent changes.

[thewilsonator]

Urgh cmake is not plying nice, but the only files that seem to be involved are
ddmd/dmodule.d
ddmd/module.h
gen/module.cpp
the storage of fqnNames was changed to be llvm::cl::location(global.params.fullyQualifiedObjectFiles

[kinke]

It doesn't have anything to do with -oq apparently.

ldc2 ..\a\bar.d ..\b\bar.d
Error: module bar from file ..\b\bar.d conflicts with another module bar from file ..\a\bar.d

Originates in DDMD's Module.parse(), where the directory containing the source file is apparently not used to form the module name.

[kinke]

DMD (a 2.072 nightly build) refuses to compile these 2 files at once too. So it looks as if you really can't compile 2 files with the same filename at once. :(

[thewilsonator]

Ok, ill raise a dmd issue.

[thewilsonator]

https://issues.dlang.org/show_bug.cgi?id=16533

[dnadlinger]

Do the files have module declarations?

[kinke]

Nope (in my example).

[thewilsonator]

Yes, original layout
dcompute/std
index.d
package.d
cuda/
index.d

[dnadlinger]

@thewilsonator: So just to be sure there are no misunderstandings, your files have module dcompute.std.index; and module dcompute.std.cuda.index?

[thewilsonator]

yes, well @compute module see https://github.com/libmir/dcompute/tree/master/source/dcompute/std

[thewilsonator]

Is this fixed by eb85bc2 ?

[kinke]

When using module declarations and -op or -oq, this should be fixed now (also tested in https://github.com/ldc-developers/dmd-testsuite/blob/ldc/compilable/ldc_output_filenames.sh).

[kinke]

@thewilsonator: Confirmed?

[thewilsonator]

Sorry for taking so long, it works.