Skip to content

[phobos] OutBuffer::vprintf - unreachable code under Win64 #197

Closed
luxtau opened this Issue Oct 12, 2012 · 4 comments

3 participants

@luxtau
luxtau commented Oct 12, 2012

Is it should work under Win64? If yes, change Win32 to Windows:



diff --git a/std/outbuffer.d b/std/outbuffer.d
index 37b1c0b..bd06caf 100644
--- a/std/outbuffer.d
+++ b/std/outbuffer.d
@@ -262,7 +262,7 @@ class OutBuffer
         auto psize = buffer.length;
         for (;;)
         {
-            version(Win32)
+            version(Windows)
             {
                 count = _vsnprintf(p,psize,f,args);
                 if (count != -1)

@klickverbot
LDC member

@redstar: This is yours.

Also, please coordinate with upstream (i.e. DMD) Phobos development. There are quite a few differences between the upstream version of Phobos and our copy right now, but we are trying to reduce them.

@redstar
LDC member
redstar commented Oct 13, 2012

@luxtau Please try the ldc-latest branch from druntime and phobos. There I merged all the upstream changes. This version should work better. It includes the changes you mentioned above.

I am going to update the Wiki soon with this information.

@luxtau
luxtau commented Oct 13, 2012

Okay, i'll try.

@redstar
LDC member
redstar commented Oct 13, 2012

I have updated the Wiki.

@redstar redstar closed this Oct 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.