-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSVC build, lots and lots of warnings #988
Comments
|
I noted this in the announcement: http://forum.dlang.org/post/ccuhfwbuzzqvpqpnhfhf@forum.dlang.org |
|
I have the exact same problem with 0.15.2 beta2 win64 :), also compilation is very slow even in debug mode. |
|
I am wondering if the root cause is this change mentioned in the LLVM release notes: |
Starting with LLVM 3.7, linkage and COMDAT are 2 different concepts. This means that LinkageODROnce does not put the object into a COMDAT. On Windows this resulted in linker error messages. This PR places all template functions, TypeInfo objects and other objects into a COMDAT.
|
Fixed in merge-2.067 branch. |
|
The situation has improved a lot, thanks Kai @redstar, but it's still present - 460 warnings left, see |
|
I see. I missed some |
Initializers and thunk code were still missing in COMDAT section.
|
Perfect, thanks a lot Kai. |
|
Damn, there are still some remains, I should have checked more carefully. :/ |
|
Finally fixed by #1087 - at least there are no more linking errors when building the runtimes and their test runners. |
Compiler: 0.15.2 beta2 win64
Test program:
Compiles + runs fine.
Only issue is well, umm https://gist.github.com/rikkimax/2db36ccd7ef65daeef84
Lots and lots of warnings.
So, given how simple that program is, any chance for a significant decrease in number of second definitions?
Or at the very least, make a note of it somewhere?
The text was updated successfully, but these errors were encountered: