[WIP] DMD inline asm: allow labels as generic operands #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadlinger
added a commit
that referenced
this pull request
Aug 7, 2015
[WIP] DMD inline asm: allow labels as generic operands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compilable/iasm_labeloperand.dis the last official 2.067 issue (edit: okay, there's still shared libs andrt.util.typeinfo-debug) on Linux x64 after David's latest commits. 👍 It uses labels as source operands formovinstructions, which is currently not supported.This commit checks whether an identifier operand is a function label, for all instructions and not just those explicitly supporting labels (
opTakesLabel()). If the instruction doesn't take labels directly, the operands yield the label's address. Not sure whether this is all it takes, but we have the first green 2.067 builds at last! :)