sections_elf_shared: Actually print error message when trying to use shared libraries with static runtime #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shared libraries with static runtime Using assert() in this module is problematic in more than one way: In debug mode, most of the assertion failures will come at a point where the runtime is not sufficiently initialised to properly throw the AssertError yet. On the other hand, in release mode, the assert(0)s will generate traps that are unhelpful for users. A patch converting the other assertions will be proposed upstream.
dnadlinger
changed the title
|
Once #2443 is in, we can also suggest that flag directly. |
PetarKirov
approved these changes
Dec 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using assert() in this module is problematic in more than one way:
In debug mode, most of the assertion failures will come at a point
where the runtime is not sufficiently initialised to properly throw
the AssertError yet. On the other hand, in release mode, the assert(0)s
will generate traps that are unhelpful for users.
A patch converting the other assertions will be proposed upstream.