Do not require gold plugin when linking with LLD #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valpackett
force-pushed
the
lld-no-plugin
branch
2 times, most recently
from
6b4d307
to
dc24817
Compare
|
hm, I wonder if lld on macos expects Darwin flags |
LLD supports plugin-style flags, but the plugin itself might not exist.
|
I guess calling |
|
I said "LLD supports plugin-style flags" for a reason :) https://github.com/llvm-mirror/lld/blob/beb1e40a02f8be0cb2c71d551d86f84d495d41e3/ELF/Options.td#L505-L521 ← it's real! (not ignored) |
|
LGTM. Can we add a test for this some way, or are we happy with not testing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLD supports plugin-style flags, but the plugin itself might not exist. (
getLTOGoldPluginPathmight fail)(on FreeBSD, it exists in an LLVM-version-specific place like
/usr/local/llvm80/lib/LLVMgold.so. that should probably be added as well, the plugin is just not required for LLD. LLD is the primary linker here,/usr/bin/ldis LLD on aarch64 and amd64.)