some fixes

[Trass3r]

collection of local patches

[Trass3r]

Ok added some more fixes esp. for Windows builds, please comment @klickverbot @redstar
In particular on the portable installation commit, not 100% sure.

Summary of lost commit comments: We should document useful llvm flags like -print-before-all, -print-after-all and -pass-remarks-analysis on the wiki etc.

[Trass3r]

Hmm now I'm (suddenly?!) hitting the "can't find curl.lib" linker problem when building phobos-test-runner.

[dnadlinger]

This needs to actually work with INCLUDE_INSTALL_DIR, as some distro packages use it. IIRC there are a couple of CMake functions for converting paths, though.

[Trass3r]

Hmm I could modify the variables to be %%ldcbinarypath%%/../... but then install doesn't work anymore. Maybe a separate conf file and a cmake switch for portable installation would be the cleanest solution.

[Trass3r]

Changed the portable installation approach. Improvement suggestions welcome.

[dnadlinger]

I merged everything but the portable installation stuff into master manually. Two issues I still see with the latter:

• The term "portable installation" isn't exactly clear, especially in the Linux world. Maybe we can come up with a better name for the flag, but at least the description should mention that it enables relative paths. Even "relocatable" would be better, but it might be confusing w.r.t. relocatable executables.
• You should probably make CMake error out if a custom INCLUDE_INSTALL_DIR is set in conjunction with your option to avoid producing a broken installation.

[Trass3r]

Thanks! Good idea to split it.
There is definitely room for improvement regarding the portable Installation. It's just a draft so far.

[dnadlinger]

I presume you are familiar enough with Git to know how to remove the already-merged commits by rebasing? If you need help, just let me know.

[dnadlinger]

@redstar, @AlexeyProkhin (and @Dicebot as one as our packages): Any creative ideas on how to handle this?

[mihails-strasuns]

What exactly seems to be a problem? I currently do this to build ldc:

    cmake \
    -DCMAKE_INSTALL_PREFIX=/usr \
    -DINCLUDE_INSTALL_DIR=/usr/include/dlang/ldc \
    ..

..and looks like it will still work after the changes as portability is switched off my default.

[dnadlinger]

@Dicebot: We can just go with Trass3r's change as is (maybe with an extra check that INCLUDE_INSTALL_DIR isn't set in addition to PORTABLE_INSTALL). I was just wondering whether we might be missing a better way to handle this.

[Trass3r]

Yeah feel free to throw in ideas :)
Is it possible that redstar doesn't receive notifications? Pinging him hasn't worked for me lately. Or commenting on his commit.

[redstar]

@Trass3r Sorry for not answering. I am a bit busy right now and do not have a good internet connection, too.

[mihails-strasuns]

I don't have any strong opinion on topic as it is not something I would usually use.

[mihails-strasuns]

Though I think removing any kind of hard-coded paths/prefixes in the binary (if there are any) and moving those to configuration is a good thing in general - then any sort of user-local installation can be done by simply copying relevant binaries.

[redstar]

I picked the assembly annotator: see #881.

[Trass3r]

Ok but please set the author correctly in the future for better tracking.

[dnadlinger]

Same thing applies still; please consider reopening isolated parts (if they still apply) as individual pull requests.