-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Set real == double on Win64 MSVC. #747
Conversation
|
Thanks Kai, that's most likely a sane decision for MSVC and may as well increase math performance (Phobos' std.math seems to encourage the use of reals, doesn't it?). Will try when I can - I'm currently using a core.stdc.math backported to LDC from dlang/druntime#968, for which I had to comment out ldc.longdouble to get rid of ambiguous symbols when linking against MSVC 2013. |
|
That whole real by default attitude in phobos is just wrong anyway, esp. for x64 and non-x86. |
|
+1 to that! Even worse, std.math implicitly assumes |
|
Note that there's also the crippled core.math. |
|
This version caused an assertion failure in |
55a04e9
to
9378624
Compare
The MS C Runtime does not support 80bit reals. Drop support in D, too.
|
I found the root cause of the assertion failure. If the Travis build goes green then I merge this pull request. |
Set real == double on Win64 MSVC.
|
Potential regression: #761 |
The MS C Runtime does not support 80bit reals. Drop support in D, too.