pkg-python: handle NULL ob in ldmud_object_create. #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See Mantis bug 902
tests: add startup.py ldmud.Object invocation. - d8f1ef6
It's possible to create a reference to an LPC object from Python using
ldmud.Object("...")
duringstartup.py
initialization. Crucially this happens before the master object is fully initialized. With LDMud 3.6.4 this early object reference works as expected. With LDMud 3.6.5 it provokes a segfault.This commit introduces a unit test that can provoke the segfault with 3.6.5 and ensure a subsequent fix doesn't regress.
pkg-python: handle NULL ob in ldmud_object_create. - 3d75c35
If
ldmud_object_create
is givenobject_t *ob == NULL
it should immediately returnNULL
instead of callingref_object(ob, ...)
, causing a segfault.This resolves Mantis bug 902.