New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for holiday feature and student model #3204

merged 4 commits into from Dec 30, 2018


None yet
3 participants
Copy link

Raycoms commented Dec 29, 2018

Changes proposed in this pull request:

  • Add male student model (monk).
  • Add config option to turn off holidays features.

Review please

Raycoms added some commits Dec 29, 2018

@ldtteam ldtteam deleted a comment from codacy-bot Dec 29, 2018

@ldtteam ldtteam deleted a comment from codacy-bot Dec 29, 2018


This comment has been minimized.

Copy link

codacy-bot commented Dec 30, 2018

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
- src/main/java/com/minecolonies/coremod/entity/  2

See the complete overview on Codacy

@ldtteam ldtteam deleted a comment from codacy-bot Dec 30, 2018

@Raycoms Raycoms merged commit 8a68e22 into version/1.12 Dec 30, 2018

4 of 5 checks passed

code-review/pullapprove Approval required by 1 of: asherslab, cltnschlosser, ldtteam-buildsystem, reggaemuffin, xavierh
Build (Branches) TeamCity build finished
Build and Test (Pull Requests) TeamCity build finished
Codacy/PR Quality Review Up to standards. A positive pull request.
license/cla Contributor License Agreement is signed.

@Raycoms Raycoms deleted the feature/student-model branch Dec 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment