Skip to content

The action prompt is confusing on the "Who pulled?" screen #62

Closed
mliu7 opened this Issue Apr 30, 2012 · 3 comments

2 participants

@mliu7
Collaborator
mliu7 commented Apr 30, 2012

To reproduce what I'm talking about, do the following:

  • Log a score event
  • Make your substitutions as usual
  • Click "Done" to take you to the main game tracking page
  • Notice that the action prompt still says "Player X throws a:" while the player prompt says "Who pulled?"

The player prompt is correct, as we want the user to select the person who pulled. The action prompt should probably not exist since the user should not be able to select any of the throws at this point. This issue is related to #39.

@mliu7
Collaborator
mliu7 commented May 7, 2012

We could use the jQuery UI dialog feature for this. It seems to be a widely accepted solution.

http://jqueryui.com/demos/dialog/

@cboulay cboulay added a commit that referenced this issue May 22, 2012
@cboulay cboulay Got rid of the multitude of substitution buttons.
Also solved #62 by passing empty text whenever we don't know the name of the player with the disc (not just when pulled, but also after a turnover). I'm waiting to close the issue until this has been merged.
3e7850d
@cboulay
Collaborator
cboulay commented Jun 20, 2012

Fixed in the chadapache branch.

@cboulay cboulay closed this Jun 20, 2012
@mliu7
Collaborator
mliu7 commented Jun 20, 2012

Good stuff, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.