Use copy_nonoverlapping in allocator realloc#248
Closed
malik672 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks! The reasoning is correct, but zk-alloc no longer has a global allocator (removed in #247) — the realloc path moved to ArenaVec::realloc_to, which already uses copy_nonoverlapping. So this is already in main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
std::ptr::copy_nonoverlappinginzk-alloc'sreallocpath.Why
For a growth
realloc, the old allocation and the new allocation should not overlap, socopy_nonoverlappingis the more precise primitive.Assembly note
copy_nonoverlappinglowers tomemcpy, whilecopylowers tomemmove.non_overlapping
and overlapping:
Validation
cargo test -p zk-alloc