Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(topology/algebra/ordered): fix assumptions in some lemmas #3629

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 30, 2020

  • Some nhds_within_I??_eq_nhds_within_I?? lemmas assumed strict
    inequalities when this was not needed.
  • Remove TFAEs that only stated equality of three nhds_withins.
    Prove equality of nhds_withins instead.
  • Genralize I??_mem_nhds_within_I?? to order_closed_topology.

This work started in #3516 by @ADedecker. I fix some issues I didn't
notice while reviewing that PR.

* Some `nhds_within_I??_eq_nhds_within_I??` lemmas assumed strict
  inequalities when this was not needed.
* Remove TFAEs that only stated equality of three `nhds_within`s.
  Prove equality of `nhds_within`s instead.
* Genralize `I??_mem_nhds_within_I??` to `order_closed_topology`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Jul 30, 2020
@ADedecker
Copy link
Member

That indeed looks better, thanks !

@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 30, 2020
bors bot pushed a commit that referenced this pull request Jul 30, 2020
* Some `nhds_within_I??_eq_nhds_within_I??` lemmas assumed strict
  inequalities when this was not needed.
* Remove TFAEs that only stated equality of three `nhds_within`s.
  Prove equality of `nhds_within`s instead.
* Genralize `I??_mem_nhds_within_I??` to `order_closed_topology`.
@bors
Copy link

bors bot commented Jul 30, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(topology/algebra/ordered): fix assumptions in some lemmas [Merged by Bors] - chore(topology/algebra/ordered): fix assumptions in some lemmas Jul 30, 2020
@bors bors bot closed this Jul 30, 2020
@bors bors bot deleted the nhds-Ici-fix branch July 30, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants