[Merged by Bors] - refactor(data/nat/*): cleanup data.nat.basic, split data.nat.choose #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryangingechen
added
the
awaiting-review
|
Thanks a lot for doing this. LGTM. |
|
Wow, thank you Bryan. This looks great. It's a hard diff to read, but I trust your report on the changes! I'm going to glance over the doc strings a bit later today, but structurally it looks ready to me, and this shouldn't sit for too long. |
|
Thanks again! bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 14, 2020
…4135) This PR rearranges `data.nat.basic` so the lemmas are now in (hopefully appropriately-named) markdown sections. It also moves several sections (mostly ones that introduced new `def`s) into new files: - `data.nat.fact` - `data.nat.psub` (maybe this could be named `data.nat.partial`?) - `data.nat.log` - `data.nat.with_bot` `data.nat.choose` has been split into a directory: - The definition of `nat.choose` and basic lemmas about it have been moved from `data.nat.basic` into `data.nat.choose.basic` - The binomial theorem and related lemmas involving sums are now in `data.nat.choose.sum`; the following lemmas are now in the `nat` namespace: - `sum_range_choose` - `sum_range_choose_halfway` - `choose_middle_le_pow` - Divisibility properties of binomial coefficients are now in `data.nat.choose.dvd`. Other changes: - added `nat.pow_two_sub_pow_two` to `data.nat.basic`. - module docs & doc strings for `data.nat.sqrt` Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
YaelDillies
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rearranges
data.nat.basicso the lemmas are now in (hopefully appropriately-named) markdown sections. It also moves several sections (mostly ones that introduced newdefs) into new files:data.nat.factdata.nat.psub(maybe this could be nameddata.nat.partial?)data.nat.logdata.nat.with_botdata.nat.choosehas been split into a directory:nat.chooseand basic lemmas about it have been moved fromdata.nat.basicintodata.nat.choose.basicdata.nat.choose.sum; the following lemmas are now in thenatnamespace:sum_range_choosesum_range_choose_halfwaychoose_middle_le_powdata.nat.choose.dvd.Other changes:
nat.pow_two_sub_pow_twotodata.nat.basic.data.nat.sqrtZulip thread.