Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed_space/inner_product): existence of orthonormal basis #5734

Closed
wants to merge 49 commits into from

Conversation

hrmacbeth
Copy link
Member

@hrmacbeth hrmacbeth commented Jan 14, 2021

Define orthonormal sets (indexed) of vectors in an inner product space E. Show that a finite-dimensional inner product space has an orthonormal basis.

Co-authored by: Busiso Chisala


@hrmacbeth hrmacbeth added the awaiting-review The author would like community review of the PR label Jan 14, 2021
src/analysis/normed_space/inner_product.lean Outdated Show resolved Hide resolved
src/analysis/normed_space/inner_product.lean Outdated Show resolved Hide resolved
src/analysis/normed_space/inner_product.lean Outdated Show resolved Hide resolved
src/linear_algebra/finite_dimensional.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 14, 2021
hrmacbeth and others added 3 commits January 14, 2021 07:25
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Copy link
Collaborator

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm very happy this is happening! And I also encourage you to do the infinite-dimensional case, it's definitely worth it.

src/analysis/normed_space/inner_product.lean Show resolved Hide resolved
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 25, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 25, 2021
@hrmacbeth hrmacbeth added the awaiting-review The author would like community review of the PR label Jan 25, 2021
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 27, 2021
@@ -595,12 +595,20 @@ lemma prod_ite_eq (f : α →₀ M) (a : α) (b : α → M → N) :
f.prod (λ x v, ite (a = x) (b x v) 1) = ite (a ∈ f.support) (b a (f a)) 1 :=
by { dsimp [finsupp.prod], rw f.support.prod_ite_eq, }

@[simp] lemma sum_ite_self_eq {N : Type*} [add_comm_monoid N] (f : α →₀ N) (a : α) :
f.sum (λ x v, ite (a = x) v 0) = f a :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ite (a = x) v 0 is basically finsupp.single x v a, for which there are plenty of lemmas about. Does the ite appear in your proof in a place where finsupp.single could be used instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this lemma is probably good to have anyway

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't succeed in massaging the use (it's in orthonormal.inner_right_finsupp) to this form.

@hrmacbeth hrmacbeth added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 28, 2021
@sgouezel
Copy link
Collaborator

bors r+
Thanks a lot for this, this is great!

bors bot pushed a commit that referenced this pull request Jan 28, 2021
…asis (#5734)

Define `orthonormal` sets (indexed) of vectors in an inner product space `E`.  Show that a finite-dimensional inner product space has an orthonormal basis.

Co-authored by: Busiso Chisala
@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 28, 2021
@bors
Copy link

bors bot commented Jan 28, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed_space/inner_product): existence of orthonormal basis [Merged by Bors] - feat(analysis/normed_space/inner_product): existence of orthonormal basis Jan 28, 2021
@bors bors bot closed this Jan 28, 2021
@bors bors bot deleted the exists-orthonormal-basis branch January 28, 2021 11:23
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
…asis (#5734)

Define `orthonormal` sets (indexed) of vectors in an inner product space `E`.  Show that a finite-dimensional inner product space has an orthonormal basis.

Co-authored by: Busiso Chisala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants