Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/list/range): Add range_zero and rename range_concat to range_succ #5821

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

The name range_concat was derived from range'_concat, where there are multiple possible expansions for range' s n.succ.
For range there is only one choice, and naming the lemma after the result rather than the statement makes it harder to find.


…ge_succ

The name `range_concat` was derived from `range'_concat`, where there are multiple possible expansions for `range' s n.succ`.
For `range` there is only one choice, and naming the lemma after the result rather than the statement makes it harder to find.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 20, 2021
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 20, 2021
bors bot pushed a commit that referenced this pull request Jan 20, 2021
…ge_succ (#5821)

The name `range_concat` was derived from `range'_concat`, where there are multiple possible expansions for `range' s n.succ`.
For `range` there is only one choice, and naming the lemma after the result rather than the statement makes it harder to find.
@bors
Copy link

bors bot commented Jan 20, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/list/range): Add range_zero and rename range_concat to range_succ [Merged by Bors] - chore(data/list/range): Add range_zero and rename range_concat to range_succ Jan 20, 2021
@bors bors bot closed this Jan 20, 2021
@bors bors bot deleted the range_nil branch January 20, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants