Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/jordan): Introduce Jordan rings #11073

Closed
wants to merge 198 commits into from

Conversation

mans0954
Copy link
Collaborator

@mans0954 mans0954 commented Dec 27, 2021

Introduces linear Jordan rings; linearises the Jordan axiom; shows that every associative ring has a symmertised product with respect to which it is a commutative Jordan ring.

Linearising the Jordan axiom is an important step towards showing that (commutative) Jordan algebras are power associative.


Open in Gitpod

@mans0954 mans0954 added the awaiting-review The author would like community review of the PR label Dec 27, 2021
@jcommelin jcommelin changed the title feat(algebra.jordan): Introduce Jordan rings feat(algebra/jordan): Introduce Jordan rings Dec 27, 2021
Copy link
Collaborator

@kmill kmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for just leaving only these insubstantial comments -- they caught my eye when reading through to see what a Jordan ring was.

src/algebra/jordan/basic.lean Outdated Show resolved Hide resolved
src/algebra/jordan/basic.lean Outdated Show resolved Hide resolved
src/algebra/jordan/basic.lean Outdated Show resolved Hide resolved
src/algebra/jordan/basic.lean Outdated Show resolved Hide resolved
src/algebra/jordan/basic.lean Outdated Show resolved Hide resolved
src/algebra/jordan/basic.lean Outdated Show resolved Hide resolved
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks great. Thanks for coming back to it. Only some very minor formatting tweaks, then feel free to merge.

bors d+

@bors
Copy link

bors bot commented Jul 25, 2022

✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 25, 2022
@eric-wieser eric-wieser added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 25, 2022
mans0954 and others added 3 commits July 25, 2022 19:57
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mans0954
Copy link
Collaborator Author

bors r+

@bors
Copy link

bors bot commented Jul 25, 2022

👎 Rejected by label

@eric-wieser
Copy link
Member

Not sure why CI is failing with no logs, I've restarted it

Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional golfing suggestion.

src/algebra/jordan/basic.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 25, 2022
Co-authored-by: Oliver Nash <github@olivernash.org>
@mans0954
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 26, 2022
Introduces linear Jordan rings; linearises the Jordan axiom; shows that every associative ring has a symmertised product with respect to which it is a commutative Jordan ring.

Linearising the Jordan axiom is an important step towards showing that (commutative) Jordan algebras are power associative.



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/jordan): Introduce Jordan rings [Merged by Bors] - feat(algebra/jordan): Introduce Jordan rings Jul 26, 2022
@bors bors bot closed this Jul 26, 2022
@bors bors bot deleted the jordan-algebras branch July 26, 2022 06:21
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
)

Introduces linear Jordan rings; linearises the Jordan axiom; shows that every associative ring has a symmertised product with respect to which it is a commutative Jordan ring.

Linearising the Jordan axiom is an important step towards showing that (commutative) Jordan algebras are power associative.



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
Introduces linear Jordan rings; linearises the Jordan axiom; shows that every associative ring has a symmertised product with respect to which it is a commutative Jordan ring.

Linearising the Jordan axiom is an important step towards showing that (commutative) Jordan algebras are power associative.



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
khwilson pushed a commit that referenced this pull request Aug 2, 2022
Introduces linear Jordan rings; linearises the Jordan axiom; shows that every associative ring has a symmertised product with respect to which it is a commutative Jordan ring.

Linearising the Jordan axiom is an important step towards showing that (commutative) Jordan algebras are power associative.



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants