This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(data/dfinsupp): add submodule.bsupr_eq_range_dfinsupp_lsum #9202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also golf some uses of `quotient.lift_on` to use `quotient.map`.
…uotient.lift_on`" This reverts commit 7f136ef.
github-actions
bot
added
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Sep 14, 2021
3 tasks
github-actions
bot
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue. A bot manages this label via PR comment.
label
Sep 16, 2021
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
eric-wieser
added
the
awaiting-review
The author would like community review of the PR
label
Sep 16, 2021
2 tasks
Vierkantor
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bors d+
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Sep 24, 2021
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
eric-wieser
changed the title
feat(data/dfinsupp): add submodule.bsupr_eq_mrange_dfinsupp_lsum
feat(data/dfinsupp): add submodule.bsupr_eq_range_dfinsupp_lsum
Sep 24, 2021
eric-wieser
commented
Sep 24, 2021
bors merge |
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Sep 24, 2021
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2021
Also a version for `add_submonoid`. Unfortunately the proofs are almost identical, but that's consistent with the surrounding bits of the file anyway. The key result is a dfinsupp version of the lemma in #8246, ```lean x ∈ (⨆ i (H : p i), f i) ↔ ∃ v : ι →₀ M, (∀ i, v i ∈ f i) ∧ ∑ i in v.support, v i = x ∧ (∀ i, ¬ p i → v i = 0) := ``` as ```lean x ∈ (⨆ i (h : p i), S i) ↔ ∃ f : Π₀ i, S i, dfinsupp.lsum ℕ (λ i, (S i).subtype) (f.filter p) = x ```
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 24, 2021
Also a version for `add_submonoid`. Unfortunately the proofs are almost identical, but that's consistent with the surrounding bits of the file anyway. The key result is a dfinsupp version of the lemma in #8246, ```lean x ∈ (⨆ i (H : p i), f i) ↔ ∃ v : ι →₀ M, (∀ i, v i ∈ f i) ∧ ∑ i in v.support, v i = x ∧ (∀ i, ¬ p i → v i = 0) := ``` as ```lean x ∈ (⨆ i (h : p i), S i) ↔ ∃ f : Π₀ i, S i, dfinsupp.lsum ℕ (λ i, (S i).subtype) (f.filter p) = x ```
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(data/dfinsupp): add submodule.bsupr_eq_range_dfinsupp_lsum
[Merged by Bors] - feat(data/dfinsupp): add submodule.bsupr_eq_range_dfinsupp_lsum
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
delegated
The PR author may merge after reviewing final suggestions.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a version for
add_submonoid
. Unfortunately the proofs are almost identical, but that's consistent with the surrounding bits of the file anyway.The key result is a dfinsupp version of the lemma in #8246,
as