LLVM: fix unboxed initializers #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes leanprover#2004. In porting the bugfix from leanprover@6eb852e, I noticed that the LLVM backend was incorrectly generating declaration initializers (in `callIODeclInitFn`), by assuming the return type of the initializer is the return type of the declaration. Rather, it must be be `lean_object`, since the initializer returns an `IO a` value which must be unpacked. TODO: stop using the `getOrCreateFunction` pattern pervasively. perform the `create` at the right location, and the `get` at the correct location.
bollu
force-pushed
the
llvm/bugfix-init-unboxed
branch
from
bc6857f to
cb8af7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2004.
In porting the bugfix from 6eb852e, I noticed that the LLVM backend was incorrectly generating declaration initializers (in
callIODeclInitFn), by assuming the return type of the initializer is the return type of the declaration. Rather, it must be belean_object, since the initializer returns anIO avalue which must be unpacked.