New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Crypto-economic Aggregate Signatures #34

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@johannbarbie
Copy link
Member

johannbarbie commented Jul 11, 2018

2dts2z

@johannbarbie johannbarbie requested review from Koroqe and troggy Jul 11, 2018

@troggy
Copy link
Member

troggy left a comment

some early feedback. View review one more time later

finalizationEpoch = lastCompleteEpoch + 1;
}
// transfer funds for bond
challenges[_period][_slotId] = Challenge(100, msg.sender, uint32(finalizationEpoch));

This comment has been minimized.

@troggy

troggy Jul 12, 2018

Member

how does a transfer of the bond happen? Isn't it just an event?

This comment has been minimized.

@troggy

troggy Jul 12, 2018

Member

ah.. it is work in progress 👍

slot.activationEpoch = 0;
// activate next guy
}
}

This comment has been minimized.

@troggy

troggy Jul 12, 2018

Member

maybe emit Slash event here?

// check signature
require(ecrecover(_period, _v, _r, _s) == slots[_slotId].signer);
// slash challenger
slots[_slotId].stake += challenges[_period][_slotId].stake / 2;

This comment has been minimized.

@troggy

troggy Jul 12, 2018

Member

tokens come out of thin air?

This comment has been minimized.

@troggy

troggy Jul 12, 2018

Member

what happens to the second half of the slashed stake?

This comment has been minimized.

@johannbarbie

johannbarbie Jul 12, 2018

Member

second half should be burned. so that the slash function is not used as a function to unstake faster than allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment