Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. LeapXRServiceProvider Changes #1019

Merged
merged 8 commits into from Apr 25, 2018

Conversation

@jselstad
Copy link
Contributor

commented Apr 24, 2018

-Fix Provider TemporalWarping bug introduced since last release (
-Fix subtle bug in Device Offsets (tilt was getting applied to Y/Z Offsets)
-Add DeviceOffsetMode Enum to choose between the default Device Offset, a custom Head-Relative Device Offset, and a Transform-based offset

(Note: Temporal Warping is disabled when using the Transform-based offset)

  • Ensure everything appears to function the way it's meant to.

@jselstad jselstad added this to the Core v4.4 milestone Apr 24, 2018

@jselstad jselstad self-assigned this Apr 24, 2018

@jselstad jselstad requested a review from nickjbenson Apr 24, 2018

jselstad and others added 3 commits Apr 25, 2018
Fix Arc Drawing by Replacing Unity's Arc Drawing Function
This is more akin to doing a normalized lerp than a spherical lerp, but its formulation is simpler (less prone to breakage).

@nickjbenson nickjbenson requested a review from Amarcolina Apr 25, 2018

@nickjbenson
Copy link
Contributor

left a comment

Approved!

@Amarcolina Amarcolina merged commit aea686c into release-4.4.0 Apr 25, 2018

@Amarcolina Amarcolina deleted the refactor-xr-provider branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.