New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing capsule hand scaling issues #855

Merged
merged 2 commits into from Sep 13, 2017

Conversation

Projects
None yet
2 participants
@Amarcolina
Contributor

Amarcolina commented Sep 11, 2017

Capsule hand meshes were not being calculated or displayed correctly at different scales. This PR should allow the hands to be displayed correctly when the camera rig changes its scale.

To test:

  • Visit the example VR scene and scale the camera rig up and down, verify that the capsule hands do not artifact in edit more or in playmode.

@Amarcolina Amarcolina added the bug label Sep 11, 2017

@Amarcolina Amarcolina self-assigned this Sep 11, 2017

@Amarcolina Amarcolina requested a review from nickjbenson Sep 11, 2017

@jselstad

This comment has been minimized.

Show comment
Hide comment
@jselstad

jselstad Sep 13, 2017

Contributor

Given Nick's latest changes, this works flawlessly too!

Contributor

jselstad commented Sep 13, 2017

Given Nick's latest changes, this works flawlessly too!

@jselstad jselstad merged commit 6520f5b into develop Sep 13, 2017

@Amarcolina Amarcolina deleted the fix-capsule-hands-at-scale branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment