Eliminate is_shared from DecorationKey #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable being present here prevents proper accumulation of multidecorate values and makes it harder to understand what's going on. Centralize the behavior and make use of trait properties when deciding whether a filter should be called.
gtremper
added a commit
that referenced
this pull request
Jun 11, 2015
Eliminate is_shared from DecorationKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable being present here prevents proper accumulation of multidecorate values and makes it harder to understand what's going on. Centralize the behavior and make use of trait properties when deciding whether a filter should be called.