Skip to content

Ensure test cleanup via RAII #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 5, 2025
Merged

Ensure test cleanup via RAII #523

merged 4 commits into from
Jul 5, 2025

Conversation

@aobolensk
Copy link
Member

@aobolensk aobolensk commented Jul 4, 2025 •
edited
Loading

  • add a ScopedFile RAII helper for test files
  • remove any temporary files in task_tests.cpp

@aobolensk aobolensk requested a review from allnes as a code owner July 4, 2025 15:26
@aobolensk aobolensk added the codex label Jul 4, 2025
@allnes allnes enabled auto-merge July 4, 2025 15:27
@codecov
Copy link

codecov bot commented Jul 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (8b3e8fb) to head (834c265).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          11       11           
  Lines         350      350           
  Branches      117      117           
=======================================
  Hits          331      331           
  Misses          5        5           
  Partials       14       14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@allnes allnes added this pull request to the merge queue Jul 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

Coverage report is available for download
here

@allnes allnes removed this pull request from the merge queue due to a manual request Jul 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

Coverage report is available for download
here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

Coverage report is available for download
here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2025

Coverage report is available for download
here

@aobolensk aobolensk added this pull request to the merge queue Jul 5, 2025
Merged via the queue into master with commit 1d7e7f8 Jul 5, 2025
81 checks passed
@aobolensk aobolensk deleted the codex/ensure-file-cleanup-in-tests branch July 7, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allnes allnes allnes approved these changes

Assignees

No one assigned

Labels

codex modules:task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aobolensk @allnes