Skip to content

Move shellcheck to pre-commit hook #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allnes merged 1 commit into from
Jul 27, 2025
Merged

Move shellcheck to pre-commit hook #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,17 @@ concurrency:
jobs:
cpp-lint:
uses: ./.github/workflows/cpp-lint.yml
shell-lint:
uses: ./.github/workflows/shell-lint.yml
ubuntu:
needs:
- cpp-lint
- shell-lint
uses: ./.github/workflows/ubuntu.yml
mac:
needs:
- cpp-lint
- shell-lint
uses: ./.github/workflows/mac.yml
windows:
needs:
- cpp-lint
- shell-lint
uses: ./.github/workflows/windows.yml
perf:
needs:
Expand Down
24 changes: 0 additions & 24 deletions .github/workflows/shell-lint.yml
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ repos:
hooks:
- id: yamllint

# Shell script linting with shellcheck
- repo: https://github.com/koalaman/shellcheck-precommit
rev: v0.10.0
hooks:
- id: shellcheck
files: \.sh$

# Configuration
default_stages: [pre-commit]
fail_fast: false
Loading