New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notification message when starting KA Lite server in windows application. #461

Merged
merged 2 commits into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
@mrpau-richard
Member

mrpau-richard commented Jun 22, 2017

Summary

This will notified the user to wait, When starting the KA Lite server.

Issues addressed

Fixes #456

@radinamatic

I would add the before opening the browser at the end of the phrase.

Another thing comes to mind: do you know if it's possible to set the duration of the time the notification bubble is visible? I sometimes find that it remains visible for too short a period, insufficient for the user to actually finish reading the message...

@benjaoming benjaoming changed the base branch from master to 0.17.x Jun 28, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 28, 2017

Member

@mrpau-richard build failure is because of the Travis update, I've fixed it in the latest master a 0.17.x branch, so if you update your PR, it will work.

Member

benjaoming commented Jun 28, 2017

@mrpau-richard build failure is because of the Travis update, I've fixed it in the latest master a 0.17.x branch, so if you update your PR, it will work.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jul 5, 2017

Member

@mrpau-richard see above regarding getting the tests to work ^

Member

benjaoming commented Jul 5, 2017

@mrpau-richard see above regarding getting the tests to work ^

@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard Jul 6, 2017

Member

@radinamatic I think the user must manually set it's duration. I found some of instructions here

Member

mrpau-richard commented Jul 6, 2017

@radinamatic I think the user must manually set it's duration. I found some of instructions here

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Jul 6, 2017

Contributor

Ok, thanks for investigating this!

Contributor

radinamatic commented Jul 6, 2017

Ok, thanks for investigating this!

@radinamatic

LGTM

@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard Jul 7, 2017

Member

Merging this.

Member

mrpau-richard commented Jul 7, 2017

Merging this.

@mrpau-richard mrpau-richard merged commit 7d9613a into learningequality:0.17.x Jul 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment