Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbundle unittest2 #3675

Closed
benjaoming opened this issue May 19, 2015 · 3 comments
Closed

Unbundle unittest2 #3675

benjaoming opened this issue May 19, 2015 · 3 comments

Comments

@benjaoming
Copy link
Contributor

I'm moving the dependency of unittest2 to requirements_dev because it isn't used anywhere else than in one test:

➜  ka-lite git:(dist-packages) ack-grep --python unittest2 kalite
kalite/basetests/tests.py
18:import unittest2
42:class DependenciesTests(unittest2.TestCase):
231:        "unittest2": "0.7.1",
363:#     suite = unittest2.TestSuite()
377:    unittest2.main(verbosity=0)

Secondary to this: Can someone maybe completely get rid of the usage of this library since it seems to be used only to test its own version and then this one single TestCase that I think could probably be implemented in a smarter way?

@aronasorman
Copy link
Collaborator

Python 2.7 has unittest2 built in. Once we move to that it will be much easier to "remove" this library. :)

@benjaoming
Copy link
Contributor Author

@aronasorman but if it's only for testing then we can just have it in requirements_dev right?

@aronasorman
Copy link
Collaborator

@benjaoming yup sure. Feel free to move it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants