New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-up form for Learners who already logged in #3926

Closed
radinamatic opened this Issue Jun 24, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@radinamatic
Contributor

radinamatic commented Jun 24, 2015

Branch: latest develop

Current Behavior: If by error Learner user presses the "Sign up" button on the homepage, and once the sign-up form appears they realize the mistake and press the Login button, after they login with modal dialog, they remain on the /securesync/signup/ page with the "Sign up for an account" content below the welcome message, and the "Sign up for an account" in the window title.

sign-up-loggedin-user

This is confusing and will make no sense to the users.

If you do the same but login as an Admin user, you will end up (correctly) on the Manage page.

Expected Behavior: I suppose most of the time Learner wants to go to "learn", or check their Progress report, the only two options they have, if I understand well. The most appropriate destination is the recommended content with Resume and the Next steps options, but this doesn't happen if by error they try to sign-up first..

Steps to reproduce:

  1. Press the "Sign up" button on the homepage
  2. Press the Login button, and enter Learner credentials inside modal dialog.
@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Jun 13, 2016

Contributor

This is still valid on 0.16, but is a fairly minor issue... Punt to 0.17 @benjaoming!

Contributor

radinamatic commented Jun 13, 2016

This is still valid on 0.16, but is a fairly minor issue... Punt to 0.17 @benjaoming!

@radinamatic radinamatic added this to the 0.17.0 milestone Jun 14, 2016

@benjaoming benjaoming self-assigned this Oct 3, 2016

@benjaoming benjaoming added the has PR label Oct 3, 2016

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Oct 3, 2016

benjaoming added a commit that referenced this issue Oct 3, 2016

Merge pull request #5315 from benjaoming/redirect-signup-login
Hotfix for signup page redirect - fixes #3926
@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Oct 3, 2016

Member

Fixed in #5315

Member

benjaoming commented Oct 3, 2016

Fixed in #5315

@benjaoming benjaoming closed this Oct 3, 2016

@benjaoming benjaoming removed the has PR label Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment