New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions in learn exercise never end #4875

Closed
manipalsingh013 opened this Issue Feb 19, 2016 · 32 comments

Comments

Projects
None yet
10 participants
@manipalsingh013
Contributor

manipalsingh013 commented Feb 19, 2016

When using exercise from learn, questions never end as they start repeating from the beginning and keep repeating.

Branch : 0.16.x
OS: Ubuntu 14.04

Steps to reproduce:

  1. Login as a Learner
  2. Choose any exercise from learn
  3. Keep answering question

Expected Behavior: Once all the question in exercise are answered by learner, he/she should get a notification regarding exercise completed.
Current Behavior: Question never end, they start to repeat from beginning and keep repeating.
exercise

@rtibbles rtibbles added the bug label Feb 19, 2016

@manipalsingh013

This comment has been minimized.

Show comment
Hide comment
@manipalsingh013

manipalsingh013 Feb 21, 2016

Contributor

I noticed that Progress bar is full i.e Quiz is complete but all questions are not covered till then, repetition starts few questions later(in some exercises)

Contributor

manipalsingh013 commented Feb 21, 2016

I noticed that Progress bar is full i.e Quiz is complete but all questions are not covered till then, repetition starts few questions later(in some exercises)

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz May 24, 2016

Hi Guys - I'm getting the same behavior on 0.16.5 for all exercises... This would seem like a bigger deal, no?

j-schwartz commented May 24, 2016

Hi Guys - I'm getting the same behavior on 0.16.5 for all exercises... This would seem like a bigger deal, no?

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles May 24, 2016

Member

I guess I am missing the point here - when the student has been judged as 'mastered' the exercise, they should get a notification.

If a student choose to continue practicing, then they will be able to continue to take the exercise for extra practice if they so wish.

I guess what I am saying is: this is intended behaviour, but perhaps the user experience is not as good as it could be if people don't realize they have achieved mastery?

Member

rtibbles commented May 24, 2016

I guess I am missing the point here - when the student has been judged as 'mastered' the exercise, they should get a notification.

If a student choose to continue practicing, then they will be able to continue to take the exercise for extra practice if they so wish.

I guess what I am saying is: this is intended behaviour, but perhaps the user experience is not as good as it could be if people don't realize they have achieved mastery?

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz May 24, 2016

Ah, what would the notification look like? Just the green bar filling up? I guess in the past I felt like when a subject was mastered they were moved on (or at least presented an option to move on) to the next video.

It seems like a bigger issue because when a user finishes watching a video, there is an error that doesn't automatically move them on to the exercises, so this seemed to me at least, to be a similar error.

rachelproject/rachelplus#56

j-schwartz commented May 24, 2016

Ah, what would the notification look like? Just the green bar filling up? I guess in the past I felt like when a subject was mastered they were moved on (or at least presented an option to move on) to the next video.

It seems like a bigger issue because when a user finishes watching a video, there is an error that doesn't automatically move them on to the exercises, so this seemed to me at least, to be a similar error.

rachelproject/rachelplus#56

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles May 25, 2016

Member

There should be, and perhaps something is awry here, a notification bar (blue in colour) that appears above the exercise frame, saying "You have finished this exercise".

Note: none of these messages will appear if no user is logged in, or the user is either a coach or an admin - these messages will only appear for student accounts.

The error in the link above looks like the error that might occur if watching a video as an admin (when it tries to save the VideoLog as an admin, it has no student user field, so cannot save the file).

If this is happening with student accounts, could you please replicate the error, and copy/paste the traceback from the Javascript console here?

Member

rtibbles commented May 25, 2016

There should be, and perhaps something is awry here, a notification bar (blue in colour) that appears above the exercise frame, saying "You have finished this exercise".

Note: none of these messages will appear if no user is logged in, or the user is either a coach or an admin - these messages will only appear for student accounts.

The error in the link above looks like the error that might occur if watching a video as an admin (when it tries to save the VideoLog as an admin, it has no student user field, so cannot save the file).

If this is happening with student accounts, could you please replicate the error, and copy/paste the traceback from the Javascript console here?

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz May 25, 2016

OK, great. I'm not sure what the desired behavior is, but here's what I've got. As a learner, after watching a video, nothing happens. To move on to exercises or the next video, a learner must go to the content tree.

As an administrator, the error message appears:

image

For exercises, as a learner, no blue notification bar appears.

I don't know how to find a traceback from the Javascript console. I'm looking up online 'traceback on javascript' or if you have instructions for it, I'll gladly do it.

j-schwartz commented May 25, 2016

OK, great. I'm not sure what the desired behavior is, but here's what I've got. As a learner, after watching a video, nothing happens. To move on to exercises or the next video, a learner must go to the content tree.

As an administrator, the error message appears:

image

For exercises, as a learner, no blue notification bar appears.

I don't know how to find a traceback from the Javascript console. I'm looking up online 'traceback on javascript' or if you have instructions for it, I'll gladly do it.

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles May 25, 2016

Member

Video wise, this sounds like expected behaviour - as long as no error is appearing for learners after watching videos, so I wouldn't worry so much about the Javascript console.

The lack of mastery notification is more concerning, I'll take a look into it.

Member

rtibbles commented May 25, 2016

Video wise, this sounds like expected behaviour - as long as no error is appearing for learners after watching videos, so I wouldn't worry so much about the Javascript console.

The lack of mastery notification is more concerning, I'll take a look into it.

@rtibbles rtibbles added this to the 0.16.6 milestone May 25, 2016

@rtibbles rtibbles self-assigned this May 25, 2016

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz commented May 25, 2016

many thanks @rtibbles

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz May 25, 2016

Maybe in the error bar, that says "sorry, ..." we could throw in a "confirm you are logged in as a user" as I know lots of usage still occurs while kids don't log in and that message may be discouraging. It's a sad reality it is very difficult to get users to create logins, but we don't want to discourage them from learning still!

j-schwartz commented May 25, 2016

Maybe in the error bar, that says "sorry, ..." we could throw in a "confirm you are logged in as a user" as I know lots of usage still occurs while kids don't log in and that message may be discouraging. It's a sad reality it is very difficult to get users to create logins, but we don't want to discourage them from learning still!

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles May 25, 2016

Member

Good idea!

Any feedback you have about ways to make the login experience better/lower friction would be interesting.

We currently have the optional 'SIMPLIFIED_LOGIN' setting, that allows users just to type in their username, and doesn't require the password, but have been wondering if we could make it simpler still.

Member

rtibbles commented May 25, 2016

Good idea!

Any feedback you have about ways to make the login experience better/lower friction would be interesting.

We currently have the optional 'SIMPLIFIED_LOGIN' setting, that allows users just to type in their username, and doesn't require the password, but have been wondering if we could make it simpler still.

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz May 25, 2016

In my experience, it's rare that kids are using the system one-on-one with a device. I know that defeats a number of the features you have, by not having logins, but it shouldn't be discouraging or undervaluing how impactful a tool this is without the student tracking info.

My vote, would be to keep logging in entirely optional, such that not logging in, does not have any adverse effects on folks.

Said another way, if I were developing this for the users I know, I would develop it in a way that not logging in doesn't have a negative impact on the experience.

The kids who do create logins, do it after months of watching videos and doing exercises without first logging in. We don't want to lose their interest in the first months while they aren't logged in yet, by throwing obstacles or discouraging notes their way.

j-schwartz commented May 25, 2016

In my experience, it's rare that kids are using the system one-on-one with a device. I know that defeats a number of the features you have, by not having logins, but it shouldn't be discouraging or undervaluing how impactful a tool this is without the student tracking info.

My vote, would be to keep logging in entirely optional, such that not logging in, does not have any adverse effects on folks.

Said another way, if I were developing this for the users I know, I would develop it in a way that not logging in doesn't have a negative impact on the experience.

The kids who do create logins, do it after months of watching videos and doing exercises without first logging in. We don't want to lose their interest in the first months while they aren't logged in yet, by throwing obstacles or discouraging notes their way.

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz May 25, 2016

From the perspective of a first time computer user, or at least first time KA-lite user, you have 90% fear of breaking something and 10% excitement.

There are lots of kids I have seen, who if they saw that sorry, something has gone wrong message, after first watching a video, will immediately close the browser and walk away for fear they have done something wrong.

The investment in computers / ka-lite / time on hardware is massive relative to school budgets, and the fear of breaking something is one of the primary obstacles I see us trying to overcome to increase adoption.

j-schwartz commented May 25, 2016

From the perspective of a first time computer user, or at least first time KA-lite user, you have 90% fear of breaking something and 10% excitement.

There are lots of kids I have seen, who if they saw that sorry, something has gone wrong message, after first watching a video, will immediately close the browser and walk away for fear they have done something wrong.

The investment in computers / ka-lite / time on hardware is massive relative to school budgets, and the fear of breaking something is one of the primary obstacles I see us trying to overcome to increase adoption.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 25, 2016

Member

There are lots of kids I have seen, who if they saw that sorry, something has gone wrong message, after first watching a video, will immediately close the browser and walk away for fear they have done something wrong.

Important observation. Adding a ticket for easy pickings about it: #5123

Member

benjaoming commented May 25, 2016

There are lots of kids I have seen, who if they saw that sorry, something has gone wrong message, after first watching a video, will immediately close the browser and walk away for fear they have done something wrong.

Important observation. Adding a ticket for easy pickings about it: #5123

@jamalex

This comment has been minimized.

Show comment
Hide comment
@jamalex

jamalex May 25, 2016

Member

I do remember an error message like that, but it would only happen for admin users, not for other user types and also not for users who aren't logged in at all. So hopefully that would address these (very valid) concerns.

I remember we cleaned some things up a while back so that error shouldn't show for admin users either, and I haven't been able to replicate it (either as a superuser or a not-logged-in user) on the demo server:
http://demo.learningequality.org/

Is it possible you logged out in one tab and left the other tab running (but it didn't know that it had been logged out)? I could imagine that might lead to something like this.

Member

jamalex commented May 25, 2016

I do remember an error message like that, but it would only happen for admin users, not for other user types and also not for users who aren't logged in at all. So hopefully that would address these (very valid) concerns.

I remember we cleaned some things up a while back so that error shouldn't show for admin users either, and I haven't been able to replicate it (either as a superuser or a not-logged-in user) on the demo server:
http://demo.learningequality.org/

Is it possible you logged out in one tab and left the other tab running (but it didn't know that it had been logged out)? I could imagine that might lead to something like this.

@jamalex

This comment has been minimized.

Show comment
Hide comment
@jamalex

jamalex May 25, 2016

Member

Nevermind, I replicated it -- only happens when the video ends naturally; there's some old code in there that tries to force a log save when the video finishes, without doing the "check that the user is logged in and isn't an admin" check that typically happens. Fix is incoming.

Member

jamalex commented May 25, 2016

Nevermind, I replicated it -- only happens when the video ends naturally; there's some old code in there that tries to force a log save when the video finishes, without doing the "check that the user is logged in and isn't an admin" check that typically happens. Fix is incoming.

@jamalex

This comment has been minimized.

Show comment
Hide comment
@jamalex

jamalex May 25, 2016

Member

Fix for the error message issue is in #5124 -- thanks for reporting!

To move on to exercises or the next video, a learner must go to the content tree.

This is "expected" behavior (we've never recommended specific follow-on content in KA Lite on the content pages, though that would of course be helpful, and is part of the design of Kolibri).

Are there any other things we've missed in this issue that are still outstanding?

Member

jamalex commented May 25, 2016

Fix for the error message issue is in #5124 -- thanks for reporting!

To move on to exercises or the next video, a learner must go to the content tree.

This is "expected" behavior (we've never recommended specific follow-on content in KA Lite on the content pages, though that would of course be helpful, and is part of the design of Kolibri).

Are there any other things we've missed in this issue that are still outstanding?

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz May 25, 2016

Fantastic, I think we still want to make sure some blue notification bar at least appears to let students know they have mastered the topic. That seems to be missing in Ubuntu installs.

j-schwartz commented May 25, 2016

Fantastic, I think we still want to make sure some blue notification bar at least appears to let students know they have mastered the topic. That seems to be missing in Ubuntu installs.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 25, 2016

Member

Are there any other things we've missed in this issue that are still outstanding?

@jamalex not by my reading: Being able to repeat the exercises is a desired feature, but not seeing when you've mastered the level is the one remaining issue.

Member

benjaoming commented May 25, 2016

Are there any other things we've missed in this issue that are still outstanding?

@jamalex not by my reading: Being able to repeat the exercises is a desired feature, but not seeing when you've mastered the level is the one remaining issue.

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic May 26, 2016

Contributor

The green bar with checkmarks is still there (0.16.5 on Ubuntu 16.04) once the exercise has been "mastered" (correct 8 of 10 answers), but it is probably insufficient as a notification by itself:

selection_448

Learners can, of course, continue doing the exercise, but we should think of adding an alert message to that effect:

Congrats, you have completed "8 out of 10" questions for this exercise! You can continue until you finish all the questions here, or you can choose another exercise.
Contributor

radinamatic commented May 26, 2016

The green bar with checkmarks is still there (0.16.5 on Ubuntu 16.04) once the exercise has been "mastered" (correct 8 of 10 answers), but it is probably insufficient as a notification by itself:

selection_448

Learners can, of course, continue doing the exercise, but we should think of adding an alert message to that effect:

Congrats, you have completed "8 out of 10" questions for this exercise! You can continue until you finish all the questions here, or you can choose another exercise.
@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz May 26, 2016

Yes, I agree it's insufficient for a learner to realize they are done,
especially because they keep earning points. A lot of kids may try to just
rack up points on easy questions for no real benefit.

I think the other thing, at least for me, would be the last part of the
note:

"You can continue until you finish all the questions here, or you can
choose another exercise."

Is that true? Does one ever finish the questions? It seems like you can
go on and on and though the questions repeat themselves, it might take
quite some time before a learner realized that. The quoted part above
seems to imply to me that at some point a learner will "finish," which I'm
not sure is accurate or identified by any behavior when that actually
occurs.

On Thu, May 26, 2016 at 9:22 AM Radina Matic notifications@github.com
wrote:

The green bar with checkmarks is still there (0.16.5 on Ubuntu 16.04) once
the exercise has been "mastered" (correct 8 of 10 answers), but it still
might be insufficient as a notification by itself:

[image: selection_448]
https://cloud.githubusercontent.com/assets/1457929/15581898/a7f477ea-236e-11e6-8a24-fe7f70145cfa.png

Learners can, of course, continue doing the exercise, but we should think
of adding an alert message to that effect:

Congrats, you have completed the "8 out of 10" questions for this exercise! You can continue until you finish all the questions here, or you can choose another exercise.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#4875 (comment)

j-schwartz commented May 26, 2016

Yes, I agree it's insufficient for a learner to realize they are done,
especially because they keep earning points. A lot of kids may try to just
rack up points on easy questions for no real benefit.

I think the other thing, at least for me, would be the last part of the
note:

"You can continue until you finish all the questions here, or you can
choose another exercise."

Is that true? Does one ever finish the questions? It seems like you can
go on and on and though the questions repeat themselves, it might take
quite some time before a learner realized that. The quoted part above
seems to imply to me that at some point a learner will "finish," which I'm
not sure is accurate or identified by any behavior when that actually
occurs.

On Thu, May 26, 2016 at 9:22 AM Radina Matic notifications@github.com
wrote:

The green bar with checkmarks is still there (0.16.5 on Ubuntu 16.04) once
the exercise has been "mastered" (correct 8 of 10 answers), but it still
might be insufficient as a notification by itself:

[image: selection_448]
https://cloud.githubusercontent.com/assets/1457929/15581898/a7f477ea-236e-11e6-8a24-fe7f70145cfa.png

Learners can, of course, continue doing the exercise, but we should think
of adding an alert message to that effect:

Congrats, you have completed the "8 out of 10" questions for this exercise! You can continue until you finish all the questions here, or you can choose another exercise.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#4875 (comment)

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 12, 2016

Member

@radinamatic - could you verify with the latest prerelease of 0.16.6 that this has been fixed?

Edit: There's nothing to verify yet.

Member

benjaoming commented Jun 12, 2016

@radinamatic - could you verify with the latest prerelease of 0.16.6 that this has been fixed?

Edit: There's nothing to verify yet.

@djallado

This comment has been minimized.

Show comment
Hide comment
@djallado

djallado Jun 16, 2016

Contributor

The checkmarks continues even if I got 104 points. I'm using KA Lite MacOS installer.
Here's my screenshot:
check

Contributor

djallado commented Jun 16, 2016

The checkmarks continues even if I got 104 points. I'm using KA Lite MacOS installer.
Here's my screenshot:
check

@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard Jun 16, 2016

Member

I also tested this on windows 7 32 bit KA Lite v0.16.6. The checkmarks still continues after 104 points.

screen shot 2016-06-17 at 3 58 46 am

Member

mrpau-richard commented Jun 16, 2016

I also tested this on windows 7 32 bit KA Lite v0.16.6. The checkmarks still continues after 104 points.

screen shot 2016-06-17 at 3 58 46 am

@j-schwartz

This comment has been minimized.

Show comment
Hide comment
@j-schwartz

j-schwartz Jun 16, 2016

@amodia @djallado I think we agreed that was OK, but that we would add a notice that the topic has been mastered once exceeding 100 points. Does that notice appear?

j-schwartz commented Jun 16, 2016

@amodia @djallado I think we agreed that was OK, but that we would add a notice that the topic has been mastered once exceeding 100 points. Does that notice appear?

@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard Jun 16, 2016

Member

@j-schwartz There's no notification shown that the topic has been mastered after I exceed 100 points.

Member

mrpau-richard commented Jun 16, 2016

@j-schwartz There's no notification shown that the topic has been mastered after I exceed 100 points.

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles Jun 16, 2016

Member

@benjaoming How would this have been fixed? I did not submit a fix for it yet.

Member

rtibbles commented Jun 16, 2016

@benjaoming How would this have been fixed? I did not submit a fix for it yet.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 17, 2016

Member

@rtibbles I don't think it's fixed, it was a fly-by misread. Previous comment is still extant:

Being able to repeat the exercises is a desired feature, but not seeing when you've mastered the level is the one remaining issue.

Member

benjaoming commented Jun 17, 2016

@rtibbles I don't think it's fixed, it was a fly-by misread. Previous comment is still extant:

Being able to repeat the exercises is a desired feature, but not seeing when you've mastered the level is the one remaining issue.

@benjaoming benjaoming modified the milestones: 0.16.7, 0.16.6 Jun 17, 2016

@needlestack

This comment has been minimized.

Show comment
Hide comment
@needlestack

needlestack Jun 20, 2016

Contributor

I'm seeing this listed as being fixed in 0.16.6:

https://groups.google.com/a/learningequality.org/forum/m/#!topic/dev/_xc6W0VUYIs

Is that info correct? It's confusing because in addition to being listed as a bug fix it is listed as a "known issue" (with the same issue ID, but a different description) under the content packs. Any insight is appreciated!

I suppose the distinction is the "mastery level" notification vs. the "all exercises complete" notification?

Contributor

needlestack commented Jun 20, 2016

I'm seeing this listed as being fixed in 0.16.6:

https://groups.google.com/a/learningequality.org/forum/m/#!topic/dev/_xc6W0VUYIs

Is that info correct? It's confusing because in addition to being listed as a bug fix it is listed as a "known issue" (with the same issue ID, but a different description) under the content packs. Any insight is appreciated!

I suppose the distinction is the "mastery level" notification vs. the "all exercises complete" notification?

@spatiald

This comment has been minimized.

Show comment
Hide comment
@spatiald

spatiald Jul 11, 2016

Not fixed in 0.16.6post1 or 0.16.7b1 - no "Mastered" notification other than the green bar and the points don't continue past 104 points. I believe this is being working for 0.16.7 milestone still, can the devs confirm?

Here is 0.16.7b1:
kalite-tracking-possible-issue

spatiald commented Jul 11, 2016

Not fixed in 0.16.6post1 or 0.16.7b1 - no "Mastered" notification other than the green bar and the points don't continue past 104 points. I believe this is being working for 0.16.7 milestone still, can the devs confirm?

Here is 0.16.7b1:
kalite-tracking-possible-issue

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 1, 2016

Member

@spatiald - you're absolutely right :( Unfortunately, there have been many issues to fix, and this one has not received a patch yet. If you look at the release notes for 0.16.7, I hope it gives hope that we didn't take stuff lightly, we just have to ship at some point and accept the state of improvements we've managed.

If we can manage to get a fix out for a 0.16.8 patch release, that would be okay.. then we should release it while still on 0.16.

Just for this particular issue, I think we should aim for 0.16.8.. otherwise, other issues should be redirected for a 0.17, unless just as serious.

Member

benjaoming commented Aug 1, 2016

@spatiald - you're absolutely right :( Unfortunately, there have been many issues to fix, and this one has not received a patch yet. If you look at the release notes for 0.16.7, I hope it gives hope that we didn't take stuff lightly, we just have to ship at some point and accept the state of improvements we've managed.

If we can manage to get a fix out for a 0.16.8 patch release, that would be okay.. then we should release it while still on 0.16.

Just for this particular issue, I think we should aim for 0.16.8.. otherwise, other issues should be redirected for a 0.17, unless just as serious.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Sep 5, 2016

Member

Fixed in #5261!

Doing a release right meow because of the severity of the issue.

Member

benjaoming commented Sep 5, 2016

Fixed in #5261!

Doing a release right meow because of the severity of the issue.

@benjaoming benjaoming closed this Sep 5, 2016

@benjaoming benjaoming removed the has PR label Sep 5, 2016

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Sep 7, 2016

Contributor

Confirming the fix meow (😺) in 0.16.9~b1-0ubuntu1!

selection_056

@benjaoming Seeing some ReactMount errors in the console but nothing in UI.

Contributor

radinamatic commented Sep 7, 2016

Confirming the fix meow (😺) in 0.16.9~b1-0ubuntu1!

selection_056

@benjaoming Seeing some ReactMount errors in the console but nothing in UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment