New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New controls for video download/managment do not scale correctly #5004

Closed
radinamatic opened this Issue Mar 17, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@radinamatic
Contributor

radinamatic commented Mar 17, 2016

Summary

Different in Firefox & Chrome, evident in locales that have longer strings than English.

Probably simple to fix, needs some design/css love... 馃槈
@66eli77 @jtamiace

Branch or installer method

Screenshots below from 0.14 installation on XP, upgraded to 0.16 (build 177), but it's general design issue.

Screenshots

Firefox, button width not enough for string length:

video-buttons-firefox

Chrome, button wide enough but overlaps the container:

video-buttons-chrome

And while you're at it, review the media queries, because the hamburger menu does not behave well below 1000px, and main menu ends up in two rows:

responsive1

responsive2

@MCGallaspy MCGallaspy added this to the 0.16.0 milestone Mar 17, 2016

@benjaoming benjaoming modified the milestones: 0.17.0, 0.16.0 Jun 18, 2016

@benjaoming benjaoming added the beginner label Jun 18, 2016

@benjaoming benjaoming modified the milestones: 0.17.0, 0.17.1 Mar 19, 2017

@benjaoming benjaoming referenced this issue Apr 14, 2017

Merged

Add line breaks in buttons so text isn't cut #5448

2 of 2 tasks complete
@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 14, 2017

Member

Fixed in #5448, let's keep an eye out for regressions in other aspects of button rendering.

Member

benjaoming commented Apr 14, 2017

Fixed in #5448, let's keep an eye out for regressions in other aspects of button rendering.

@benjaoming benjaoming closed this Apr 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment