New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total exercise attempted number on Coach report is not displaying the correct numbers - Verision 0.15 #5020

Closed
harishbalachandran opened this Issue Mar 21, 2016 · 9 comments

Comments

Projects
None yet
5 participants
@harishbalachandran

harishbalachandran commented Mar 21, 2016

Detailed description:
Total exercise attempted on the coach report does not show the correct number for the date range selected.
Expected behavior:
The exercise attempted should show the exact number of the attempted exercise for the selected date range.
Actual behavior:
Upon attempting 1 exercise for the selected date range, Exercise attempted should be shown as 1 , instead the number is displayed as 2.

Note: I attempted 1 exercise and 2 questions of "Counting with small numbers"

Please refer the screenshots for more details.
screen shot 2016-03-21 at 4 30 16 pm
screen shot 2016-03-21 at 4 31 27 pm
screen shot 2016-03-21 at 4 32 17 pm

@sethachoi

This comment has been minimized.

Show comment
Hide comment
@sethachoi

sethachoi Mar 25, 2016

Contributor

Report is accurate, but bug or feature? If feature we should rename "exercise attempts" to "question attempts" or something.

To clarify, as of 0.16.x, each question is being counted as an exercise attempt, rather than the exercise itself as one attempt.

@rtibbles

Contributor

sethachoi commented Mar 25, 2016

Report is accurate, but bug or feature? If feature we should rename "exercise attempts" to "question attempts" or something.

To clarify, as of 0.16.x, each question is being counted as an exercise attempt, rather than the exercise itself as one attempt.

@rtibbles

@harishbalachandran

This comment has been minimized.

Show comment
Hide comment
@harishbalachandran

harishbalachandran Mar 25, 2016

Oh, Just to confirm "exercise attempted" displayed is number of questions attempted attempted for that date range.

Then in that case we should rename it to number of Questions attempted instead of Exercise attempted.
Because as a teacher I will be really confused.

harishbalachandran commented Mar 25, 2016

Oh, Just to confirm "exercise attempted" displayed is number of questions attempted attempted for that date range.

Then in that case we should rename it to number of Questions attempted instead of Exercise attempted.
Because as a teacher I will be really confused.

@sethachoi

This comment has been minimized.

Show comment
Hide comment
@sethachoi

sethachoi Mar 25, 2016

Contributor

Sorry if it was unclear, once again I was just confirming and jotting down notes that the bug is present in 0.16 and not just 0.15

Contributor

sethachoi commented Mar 25, 2016

Sorry if it was unclear, once again I was just confirming and jotting down notes that the bug is present in 0.16 and not just 0.15

@harishbalachandran

This comment has been minimized.

Show comment
Hide comment
@harishbalachandran

harishbalachandran Mar 25, 2016

Oh! sorry I miss understood. Thanks. 💯

harishbalachandran commented Mar 25, 2016

Oh! sorry I miss understood. Thanks. 💯

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles Mar 26, 2016

Member

The clarification here is that 'exercise attempts' means 'attempts at an exercise' not 'exercises attempted'.

If it said 'Exercises attempted' it would mean the latter. I agree that a change in wording would probably be good.

Member

rtibbles commented Mar 26, 2016

The clarification here is that 'exercise attempts' means 'attempts at an exercise' not 'exercises attempted'.

If it said 'Exercises attempted' it would mean the latter. I agree that a change in wording would probably be good.

@rtibbles rtibbles added this to the 0.17.0 milestone Mar 26, 2016

@benjaoming benjaoming modified the milestones: 0.17.0, 0.17.1 Mar 19, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 7, 2017

Member

I disagree on changing language. I've just fixed it so that numbers add up (the graph below showing struggling, in progress, and completed). So everything is now about exercise attempts.

Before, this was possible:

screenshot from 2017-04-07 14-02-56

A teacher with no background in this, supposing to understand these coach report, will scratch her head about these figures.

Member

benjaoming commented Apr 7, 2017

I disagree on changing language. I've just fixed it so that numbers add up (the graph below showing struggling, in progress, and completed). So everything is now about exercise attempts.

Before, this was possible:

screenshot from 2017-04-07 14-02-56

A teacher with no background in this, supposing to understand these coach report, will scratch her head about these figures.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 7, 2017

Member

Btw. what the above example is meant to show: During some period, there has been 17 exercise attempts recorded, however data has been updated on latest_activity_timestamp for loads more exercises (0 + 39 + 188).

I have no intention of finding out why, so instead I'll leave the "Total exercise attempts" (so we don't bother translators) and assume that it appeals to some level of intuition.

Member

benjaoming commented Apr 7, 2017

Btw. what the above example is meant to show: During some period, there has been 17 exercise attempts recorded, however data has been updated on latest_activity_timestamp for loads more exercises (0 + 39 + 188).

I have no intention of finding out why, so instead I'll leave the "Total exercise attempts" (so we don't bother translators) and assume that it appeals to some level of intuition.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 7, 2017

Member

After the change:

screenshot from 2017-04-07 14-56-45

Member

benjaoming commented Apr 7, 2017

After the change:

screenshot from 2017-04-07 14-56-45

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Apr 7, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 7, 2017

Member

Fixed in #5435

Member

benjaoming commented Apr 7, 2017

Fixed in #5435

@benjaoming benjaoming closed this Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment