New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to leave 2015 behind... #5055

Closed
radinamatic opened this Issue Mar 28, 2016 · 10 comments

Comments

Projects
None yet
3 participants
@radinamatic
Contributor

radinamatic commented Mar 28, 2016

Summary

Footer still displays year 2015:

year

I have PR practically ready, changed the _footer.html, but what about the line 297 in kalite/settings/base.py, does that need changing too? It's Khan Academy, not KA Lite:

 "footer_text": ugettext_lazy(u"Videos © 2015 Khan Academy (Creative Commons) // Exercises © 2015 Khan Academy"),

If somebody confirms this (@aronasorman, @jamalex), I can push the PR.

@aronasorman aronasorman added this to the 0.17.0 milestone Mar 28, 2016

@aronasorman

This comment has been minimized.

Show comment
Hide comment
@aronasorman

aronasorman Mar 28, 2016

Member

@radinamatic too late, we had the string freeze (aka uploaded the po files) 2 weeks ago. No more string changes at this point.

Member

aronasorman commented Mar 28, 2016

@radinamatic too late, we had the string freeze (aka uploaded the po files) 2 weeks ago. No more string changes at this point.

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Mar 28, 2016

Contributor

That "string" is a year number, how important is it to be translated? 😛
@aronasorman

Contributor

radinamatic commented Mar 28, 2016

That "string" is a year number, how important is it to be translated? 😛
@aronasorman

@aronasorman

This comment has been minimized.

Show comment
Hide comment
@aronasorman

aronasorman Mar 28, 2016

Member

I see that string translated sometimes, so I can't assume that it's unimportant for translators. I'm holding steadfast on this one.

Member

aronasorman commented Mar 28, 2016

I see that string translated sometimes, so I can't assume that it's unimportant for translators. I'm holding steadfast on this one.

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Mar 28, 2016

Contributor

Ok, ok...
It's just a pity to have the last year there... 😧

Contributor

radinamatic commented Mar 28, 2016

Ok, ok...
It's just a pity to have the last year there... 😧

@aronasorman

This comment has been minimized.

Show comment
Hide comment
@aronasorman

aronasorman Mar 28, 2016

Member

Yeah, alas...

feel free to open a PR targeting develop and 0.16.x, so that it can be merged in once 0.16.0 has been released!

Member

aronasorman commented Mar 28, 2016

Yeah, alas...

feel free to open a PR targeting develop and 0.16.x, so that it can be merged in once 0.16.0 has been released!

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 2, 2016

Member

@aronasorman this was a straight-forward fix, I don't think the string freeze policy was warranted.. will release next time around.

Member

benjaoming commented May 2, 2016

@aronasorman this was a straight-forward fix, I don't think the string freeze policy was warranted.. will release next time around.

@benjaoming benjaoming modified the milestones: 0.16.6, 0.17.0 May 2, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 2, 2016

Member

Ah okay not all of it, but most of it, I'll get to the channel footer text, too when I figure out string formatting for ugettext_lazy.

Member

benjaoming commented May 2, 2016

Ah okay not all of it, but most of it, I'll get to the channel footer text, too when I figure out string formatting for ugettext_lazy.

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Jun 13, 2016

Contributor

Issue is still "officially" assigned to me, but not sure if your PR fixed it and can be closed, or if it's still WIP...? @benjaoming

Contributor

radinamatic commented Jun 13, 2016

Issue is still "officially" assigned to me, but not sure if your PR fixed it and can be closed, or if it's still WIP...? @benjaoming

@benjaoming benjaoming modified the milestones: 0.17.0, 0.16.6 Jun 14, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 14, 2016

Member

It was only partially fixed as you'll see in the footer of 0.16.6 :)

Member

benjaoming commented Jun 14, 2016

It was only partially fixed as you'll see in the footer of 0.16.6 :)

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Oct 2, 2016

@benjaoming benjaoming referenced this issue Oct 2, 2016

Merged

Use current year in channel footer text #5307

3 of 3 tasks complete

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Oct 2, 2016

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Oct 2, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Oct 2, 2016

Member

Fixed in #5307

Member

benjaoming commented Oct 2, 2016

Fixed in #5307

@benjaoming benjaoming closed this Oct 2, 2016

@benjaoming benjaoming removed the has PR label Oct 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment