New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging is broken in production on Windows #5057

Closed
jamalex opened this Issue Mar 28, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@jamalex
Member

jamalex commented Mar 28, 2016

Summary

Logging to file was not working on Windows, as seen in #5030 -- seems likely to be multi-threaded concurrency issues (possibly StreamHandler being closed by one thread while still being used by another thread).

A temporary workaround to avoid bigger problems was introduced by #5056, but it simply disables the StreamHandler output on Windows, thereby disabling logging.

We should remove the workaround introduced in #5056, and then sort out the original problem to get logging working properly again.

Branch or installer method

  • Branch: 0.16.x

@jamalex jamalex added the bug label Mar 28, 2016

@jamalex jamalex added this to the 0.17.0 milestone Mar 28, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 13, 2016

Member

I don't have a Windows dev environment so I'm likely the wrong person to assign.

However, this is a very critical bug troubleshooting windows deployment issues is made extremely difficult without proper logging.

Member

benjaoming commented Jun 13, 2016

I don't have a Windows dev environment so I'm likely the wrong person to assign.

However, this is a very critical bug troubleshooting windows deployment issues is made extremely difficult without proper logging.

@benjaoming benjaoming removed their assignment Jun 13, 2016

@jamalex

This comment has been minimized.

Show comment
Hide comment
@jamalex

jamalex Jun 13, 2016

Member

I don't have a Windows dev environment so I'm likely the wrong person to assign.

I assigned you as you're our Django/logging expert; not sure who might be better to take it on (only people with Windows are frontend devs and interns), but feel free to attempt a re-assign. I did my initial debugging for this using a Virtualbox from: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/linux/

Member

jamalex commented Jun 13, 2016

I don't have a Windows dev environment so I'm likely the wrong person to assign.

I assigned you as you're our Django/logging expert; not sure who might be better to take it on (only people with Windows are frontend devs and interns), but feel free to attempt a re-assign. I did my initial debugging for this using a Virtualbox from: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/linux/

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Sep 7, 2016

Member

Usual work-around (modify the paths in case you don't have Python installed in C:\Python27).

C:>cd C:\Python27
C:\Python27>cd Scripts
C:\Python27\Scripts>kalite start --foreground
Member

benjaoming commented Sep 7, 2016

Usual work-around (modify the paths in case you don't have Python installed in C:\Python27).

C:>cd C:\Python27
C:\Python27>cd Scripts
C:\Python27\Scripts>kalite start --foreground
@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard Sep 26, 2016

Member

Hi @benjaoming It's safe if we use the kalite start --foreground when starting the KA Lite server?
If that safe then we use it to Start the KA Lite server in the KA Lite windows application.

Member

mrpau-richard commented Sep 26, 2016

Hi @benjaoming It's safe if we use the kalite start --foreground when starting the KA Lite server?
If that safe then we use it to Start the KA Lite server in the KA Lite windows application.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Sep 26, 2016

Member

@mrpau-richard the solution we're looking for is to get the actual Python logging work so that logging is completely identical on all systems.

The above is just a work-around, not a fix :)

Member

benjaoming commented Sep 26, 2016

@mrpau-richard the solution we're looking for is to get the actual Python logging work so that logging is completely identical on all systems.

The above is just a work-around, not a fix :)

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming
Member

benjaoming commented Dec 19, 2016

Fixed by @mrpau-richard in #5364

@benjaoming benjaoming closed this Dec 19, 2016

@benjaoming benjaoming removed the has PR label Dec 19, 2016

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment