New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write content to staticfiles dirs #5073

Closed
rtibbles opened this Issue Apr 4, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@rtibbles
Member

rtibbles commented Apr 4, 2016

Summary

Currently we unpack Khan Exercise translated html templates, and subtitle files into the collected static files folder.

We should instead put them into the content folder - this would avoid issues with overwriting when we force collectstatic to clear all files, and also mean that we can better test these features in debug mode also.

Branch or installer method

Branch: master

@rtibbles rtibbles added this to the 0.17.0 milestone Apr 4, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Sep 20, 2016

Member

It sounds like a bug? Does it mean that collectstatic will effectively remove parts of an unpacked content pack?

Member

benjaoming commented Sep 20, 2016

It sounds like a bug? Does it mean that collectstatic will effectively remove parts of an unpacked content pack?

@benjaoming benjaoming added the bug label Sep 20, 2016

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles Sep 20, 2016

Member

Potentially it could. It also makes dev with these features harder, because this can only be tested in production mode.

Member

rtibbles commented Sep 20, 2016

Potentially it could. It also makes dev with these features harder, because this can only be tested in production mode.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Oct 3, 2016

Member

Some notes

subtitles:
.kalite/httpsrv/static/srt

metadata + locale files in locale dir
.kalite/locale

assessment item data go to
.kalite/content/assessment

html exercises go to:
.kalite/httpsrv/static/js/distributed/perseus/exercises/<lang_code>

Member

benjaoming commented Oct 3, 2016

Some notes

subtitles:
.kalite/httpsrv/static/srt

metadata + locale files in locale dir
.kalite/locale

assessment item data go to
.kalite/content/assessment

html exercises go to:
.kalite/httpsrv/static/js/distributed/perseus/exercises/<lang_code>

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jan 17, 2017

Member

Fixed in #5386

Member

benjaoming commented Jan 17, 2017

Fixed in #5386

@benjaoming benjaoming closed this Jan 17, 2017

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment