New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating lockdown causes page redirect error #5117

Closed
Aypak opened this Issue May 11, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@Aypak
Contributor

Aypak commented May 11, 2016

Summary

Activating the setting LOCKDOWN = True in settings.py to prevent users from accessing exercises and videos without logging in causes a page redirect error ERR_TOO_MANY_REDIRECTS.

Branch or installer method

  • Installer: Debian
  • Version: 0.16.5

How to reproduce

  1. Add the line LOCKDOWN = True to settings.py
  2. Restart ka-lite

Screenshots

screenshot from 2016-05-11 17 03 28

Real-life consequences (anything community should be aware, for instance how it affects your deployment)

Capturing student activity data is really important to us. When students are not supervised they sometimes watch videos or do exercises without logging in, and their progress is not recorded. This would be a good way to 'force' students to log in.

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Jun 11, 2016

@benjaoming benjaoming self-assigned this Jun 11, 2016

@benjaoming benjaoming added the has PR label Jun 11, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 11, 2016

Member

Hi @Aypak - I agree with your description and it's easy to recreate.

Luckily it was also easy to fix!

If you want to test it, feel free, otherwise we're closing this issue as soon as the PR is merged.

Member

benjaoming commented Jun 11, 2016

Hi @Aypak - I agree with your description and it's easy to recreate.

Luckily it was also easy to fix!

If you want to test it, feel free, otherwise we're closing this issue as soon as the PR is merged.

@Aypak

This comment has been minimized.

Show comment
Hide comment
@Aypak

Aypak Jun 13, 2016

Contributor

Thanks @benjaoming ! I will confirm as soon as I test

Contributor

Aypak commented Jun 13, 2016

Thanks @benjaoming ! I will confirm as soon as I test

benjaoming added a commit that referenced this issue Jun 14, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 14, 2016

Member

Fixed in #5150 and merged to have it in 0.16.6. Thanks for the report @Aypak !

Member

benjaoming commented Jun 14, 2016

Fixed in #5150 and merged to have it in 0.16.6. Thanks for the report @Aypak !

@benjaoming benjaoming closed this Jun 14, 2016

@benjaoming benjaoming removed the has PR label Jun 14, 2016

@kenny55d

This comment has been minimized.

Show comment
Hide comment
@kenny55d

kenny55d Jul 11, 2016

Please did anyone get a chance to test this? I have just tested it on my system (RPi3 with 0.16.6post1) but I am unable to login when LOCKDOWN=True, I get the login prompt but nothing happens when I select login; Is anyone getting the same or is it just me?

kenny55d commented Jul 11, 2016

Please did anyone get a chance to test this? I have just tested it on my system (RPi3 with 0.16.6post1) but I am unable to login when LOCKDOWN=True, I get the login prompt but nothing happens when I select login; Is anyone getting the same or is it just me?

@kenny55d

This comment has been minimized.

Show comment
Hide comment
@kenny55d

kenny55d Jul 11, 2016

selection_002

When I select login, I get the following output in the terminal despite the fact that the same user can login when LOCKDOWN is disabled but with LOCKDOWN enabled, permission is denied:

selection_003

kenny55d commented Jul 11, 2016

selection_002

When I select login, I get the following output in the terminal despite the fact that the same user can login when LOCKDOWN is disabled but with LOCKDOWN enabled, permission is denied:

selection_003

@Aypak

This comment has been minimized.

Show comment
Hide comment
@Aypak

Aypak Jul 11, 2016

Contributor

Hi @kenny55d , I have just tested and get the same result as above. @benjaoming, I'm sorry I didn't test this much sooner. My hunch is that the url "/securesync/api/user/login" is not whitelisted when lockdown is activated. I hope this is an easy fix.

Contributor

Aypak commented Jul 11, 2016

Hi @kenny55d , I have just tested and get the same result as above. @benjaoming, I'm sorry I didn't test this much sooner. My hunch is that the url "/securesync/api/user/login" is not whitelisted when lockdown is activated. I hope this is an easy fix.

@Aypak

This comment has been minimized.

Show comment
Hide comment
@Aypak

Aypak Jul 13, 2016

Contributor

Just submitted pull request #5202 to fix this

Contributor

Aypak commented Jul 13, 2016

Just submitted pull request #5202 to fix this

@kenny55d

This comment has been minimized.

Show comment
Hide comment
@kenny55d

kenny55d Jul 13, 2016

@Aypak Just tested the change you made and it appears to have fixed the login issue. Thanks.

kenny55d commented Jul 13, 2016

@Aypak Just tested the change you made and it appears to have fixed the login issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment