New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclean shutdown in OS X installer #5211

Closed
arceduardvincent opened this Issue Jul 26, 2016 · 15 comments

Comments

Projects
None yet
4 participants
@arceduardvincent
Member

arceduardvincent commented Jul 26, 2016

Summary

I can install it successfully and start the server but when I load it in browser the server will quit.

Branch or installer method

  • Installer: OSX
  • Version: 0.16.7b3
  • Branch: 0.16.x

Screenshots

f052b7f2-3e69-11e6-9087-7492e24338db

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 1, 2016

Member

We have to leave this as a "known issue" for now since there are so many bug fixes in 0.16.7 at this point, it makes no sense to delay it any further.

Member

benjaoming commented Aug 1, 2016

We have to leave this as a "known issue" for now since there are so many bug fixes in 0.16.7 at this point, it makes no sense to delay it any further.

@arceduardvincent

This comment has been minimized.

Show comment
Hide comment
@arceduardvincent

arceduardvincent Aug 1, 2016

Member

@cpauya and I discuss about this. We agree on that this issue will remain as "known issue" for now. We apologise for the delay of this fix. We will follow up this fix #5212 as soon as possible.

Member

arceduardvincent commented Aug 1, 2016

@cpauya and I discuss about this. We agree on that this issue will remain as "known issue" for now. We apologise for the delay of this fix. We will follow up this fix #5212 as soon as possible.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 2, 2016

Member

@arceduardvincent could this be related to the way that Pyrun is built for the installer? It seems a similar issue has been solved previously regarding downloads... learningequality/ka-lite-installers#100

Member

benjaoming commented Aug 2, 2016

@arceduardvincent could this be related to the way that Pyrun is built for the installer? It seems a similar issue has been solved previously regarding downloads... learningequality/ka-lite-installers#100

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 2, 2016

Member

But the mystery of this issue is also a great motivational factor for: learningequality/ka-lite-installers#98

Member

benjaoming commented Aug 2, 2016

But the mystery of this issue is also a great motivational factor for: learningequality/ka-lite-installers#98

@arceduardvincent

This comment has been minimized.

Show comment
Hide comment
@arceduardvincent

arceduardvincent Aug 2, 2016

Member

@benjaoming Yeah, maybe similar on the video downloads issue.
However the mystery on this Unclean shutdown, if we downgrade requests>=1.0,<1.2.3.
The Unclean shutdown will not replicate.

Member

arceduardvincent commented Aug 2, 2016

@benjaoming Yeah, maybe similar on the video downloads issue.
However the mystery on this Unclean shutdown, if we downgrade requests>=1.0,<1.2.3.
The Unclean shutdown will not replicate.

@arceduardvincent

This comment has been minimized.

Show comment
Hide comment
@arceduardvincent

arceduardvincent Aug 2, 2016

Member

@benjaoming I think we will venture some alternatives for pyrun like PEX or Virtualenv perhaps.
What are your thoughts @cpauya about this?

Member

arceduardvincent commented Aug 2, 2016

@benjaoming I think we will venture some alternatives for pyrun like PEX or Virtualenv perhaps.
What are your thoughts @cpauya about this?

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 2, 2016

Member

@arceduardvincent - I've just checked out the documentation for requests 1.1.0 and it seems it has the stream=True option for get() which was my main concern since I just refactored all the video download stuff to use requests.

We could try to change to use 1.1.0?

The problem must somehow be in the Python libraries that requests expects and that Pyrun supplies.... brokenly...

Member

benjaoming commented Aug 2, 2016

@arceduardvincent - I've just checked out the documentation for requests 1.1.0 and it seems it has the stream=True option for get() which was my main concern since I just refactored all the video download stuff to use requests.

We could try to change to use 1.1.0?

The problem must somehow be in the Python libraries that requests expects and that Pyrun supplies.... brokenly...

@arceduardvincent

This comment has been minimized.

Show comment
Hide comment
@arceduardvincent

arceduardvincent Aug 2, 2016

Member

@benjaoming Thanks for helping.

Yeah we can use requests==1.1.0. Are we ok using this requests version?
This version of requests is working see image attach.
screen shot 2016-08-02 at 10 15 23 pm

The video download is ok.
screen shot 2016-08-03 at 1 43 55 am

Member

arceduardvincent commented Aug 2, 2016

@benjaoming Thanks for helping.

Yeah we can use requests==1.1.0. Are we ok using this requests version?
This version of requests is working see image attach.
screen shot 2016-08-02 at 10 15 23 pm

The video download is ok.
screen shot 2016-08-03 at 1 43 55 am

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 2, 2016

Member

I would be okay with that, as long as we just test the basic things that invoke requests: Content pack and video downloads and the legacy assessment item download.

Member

benjaoming commented Aug 2, 2016

I would be okay with that, as long as we just test the basic things that invoke requests: Content pack and video downloads and the legacy assessment item download.

@arceduardvincent

This comment has been minimized.

Show comment
Hide comment
@arceduardvincent

arceduardvincent Aug 2, 2016

Member

@benjaoming Ok working on it now. So we can have a OS X installer release too.

Member

arceduardvincent commented Aug 2, 2016

@benjaoming Ok working on it now. So we can have a OS X installer release too.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 2, 2016

Member

No, not for 0.16.7 -- but for 0.16.8 we will :) As I said, as soon as this issue is fixed, we should release 0.16.8 so we won't have much pause. No problem in releasing often when we fix critical stuff :)

Member

benjaoming commented Aug 2, 2016

No, not for 0.16.7 -- but for 0.16.8 we will :) As I said, as soon as this issue is fixed, we should release 0.16.8 so we won't have much pause. No problem in releasing often when we fix critical stuff :)

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 2, 2016

Member

0.16.7 is already almost totally shipped :)

Member

benjaoming commented Aug 2, 2016

0.16.7 is already almost totally shipped :)

@arceduardvincent

This comment has been minimized.

Show comment
Hide comment
@arceduardvincent

arceduardvincent Aug 2, 2016

Member

Yeah. I forgot that :).

So far I have tested content pack, video downloads and the assessment item are working.
screen shot 2016-08-03 at 1 57 28 am
screen shot 2016-08-03 at 2 10 27 am

Member

arceduardvincent commented Aug 2, 2016

Yeah. I forgot that :).

So far I have tested content pack, video downloads and the assessment item are working.
screen shot 2016-08-03 at 1 57 28 am
screen shot 2016-08-03 at 2 10 27 am

@benjaoming benjaoming referenced this issue Aug 3, 2016

Merged

Downgrade requests because of pyrun issue #5241

3 of 3 tasks complete

@benjaoming benjaoming closed this in beedeb7 Aug 5, 2016

@benjaoming benjaoming removed the has PR label Aug 5, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 17, 2016

Member

Downgrading requests already caused the first issue it could seem?

#5257

Member

benjaoming commented Aug 17, 2016

Downgrading requests already caused the first issue it could seem?

#5257

@mrpau-eduard

This comment has been minimized.

Show comment
Hide comment
@mrpau-eduard

mrpau-eduard Aug 29, 2016

Member

@benjaoming it seems that the downgrading the requests cause the issue #5257. Based on "Short time work around" by @fheslouin.
For the next release, we will implement PEX to replace pryun then we will upgrade the requests to requests==2.10.0.

Member

mrpau-eduard commented Aug 29, 2016

@benjaoming it seems that the downgrading the requests cause the issue #5257. Based on "Short time work around" by @fheslouin.
For the next release, we will implement PEX to replace pryun then we will upgrade the requests to requests==2.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment