New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship w/ empty content.db, handle blank default installations #5318

Closed
benjaoming opened this Issue Oct 4, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@benjaoming
Member

benjaoming commented Oct 4, 2016

Summary

We ship a broken default content pack (English content.db w/o assessment items or subtitles, means that you can click exercises but they're broken) - that alone is a solid enough reason to stop building this content pack and instead fix KA Lite.

The other reason is the 90 MB of almost meaningless data (unpacked, ~50 MB download size) that we bundle into the source distribution. This used to make sense, but since it's now entirely overwritten by the content pack, it seems like an irresponsible waste of resources IMO.

This means we should auto-redirect to the Manage tab when user hasn't installed any content.db.

Issue about removing en-minimal.zip from content pack maker:
learningequality/ka-lite-content-packs#40

TODO

  • Make tests etc. function with a fixture based on an empty content.db
  • The whole app should function without ANY content.db at all
  • Add sensitive messages explaining the lack of a content db
  • Consolidate the display of installed content pack, as it probably suffers from some adjustments made to accommodate the legacy "minimal" contentpack

@benjaoming benjaoming added this to the 0.17.0 milestone Oct 4, 2016

@benjaoming benjaoming self-assigned this Oct 4, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Oct 10, 2016

Member
  • the danger of having wrong versions of the bundled English minimal content pack means that there is no "Upgrade" button visible unless we edit metadata on the server Manually. So we can't release without addressing this.
Member

benjaoming commented Oct 10, 2016

  • the danger of having wrong versions of the bundled English minimal content pack means that there is no "Upgrade" button visible unless we edit metadata on the server Manually. So we can't release without addressing this.

@benjaoming benjaoming changed the title from Ship without content.db, handle blank default installations to Ship w/ empty content.db, handle blank default installations Oct 20, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Nov 28, 2016

Member

It seems that the database and possibly also subtitle files are affected by upgrades, I'm suspecting that the pre-bundled minimal content pack is to blame, but should investigate further.

As of now, it seems certain that when I switch from 0.17b2 with the latest full en content pack with correct subtitle annotations and to develop, I get all the subtitles wrongly annotated, something that looks like a pre-bundled minimal content.db.

Member

benjaoming commented Nov 28, 2016

It seems that the database and possibly also subtitle files are affected by upgrades, I'm suspecting that the pre-bundled minimal content pack is to blame, but should investigate further.

As of now, it seems certain that when I switch from 0.17b2 with the latest full en content pack with correct subtitle annotations and to develop, I get all the subtitles wrongly annotated, something that looks like a pre-bundled minimal content.db.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Dec 2, 2016

Member

The .whl source files have reduced from 52 MB til 31 MB, expecting similar results in debian packages and installers because they contain the source distribution in which the English content.db is overwritten after installation.

It should also have a performance-wise impact because content annotation no longer takes place twice (at first setup, then after content pack installation).

Member

benjaoming commented Dec 2, 2016

The .whl source files have reduced from 52 MB til 31 MB, expecting similar results in debian packages and installers because they contain the source distribution in which the English content.db is overwritten after installation.

It should also have a performance-wise impact because content annotation no longer takes place twice (at first setup, then after content pack installation).

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Dec 17, 2016

Member

Fixed in #5350

Member

benjaoming commented Dec 17, 2016

Fixed in #5350

@benjaoming benjaoming closed this Dec 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment