New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar is missing when downloading a Kiswahili videos. #5321

Closed
mrpau-richard opened this Issue Oct 6, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@mrpau-richard
Member

mrpau-richard commented Oct 6, 2016

Summary

Progress bar is missing when downloading a Kiswahili videos.

System information

  • Mac OS X 10.11.6
  • 0.16.9

How to reproduce

  1. download a Kiswahili language pack at http://pantry.learningequality.org/downloads/ka-lite/0.16/content/contentpacks/
  2. Used it in KA Lite.
  3. Download any Kiswahili videos.

Screenshots

Downloading Kiswahili videos.
screen shot 2016-10-06 at 5 28 58 pm

Downloading English videos.
screen shot 2016-10-06 at 5 31 37 pm

/cc: @julianharty

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Oct 6, 2016

Member

@mrpau-richard - see any javascript errors or errors in your server.log?

Member

benjaoming commented Oct 6, 2016

@mrpau-richard - see any javascript errors or errors in your server.log?

@mrpau-richard

This comment has been minimized.

Show comment
Hide comment
@mrpau-richard

mrpau-richard Oct 7, 2016

Member

@benjaoming I have this console error.
screen shot 2016-10-07 at 6 04 34 am

Member

mrpau-richard commented Oct 7, 2016

@benjaoming I have this console error.
screen shot 2016-10-07 at 6 04 34 am

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Oct 7, 2016

Member

@mrpau-richard - you should also expand the SyntaxError so it's possible to actually read the traceback :)

Member

benjaoming commented Oct 7, 2016

@mrpau-richard - you should also expand the SyntaxError so it's possible to actually read the traceback :)

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Oct 10, 2016

Member

Thanks for the fix @mrpau-eduard - changes will be implemented for 0.17

Member

benjaoming commented Oct 10, 2016

Thanks for the fix @mrpau-eduard - changes will be implemented for 0.17

@benjaoming benjaoming closed this Oct 10, 2016

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene Jul 19, 2017

Member

@benjaoming -- @mrpau-eduard explained to me that the progress bar doesn't show when downloading sw videos. So, I checked on updates/base.js first to see if I can do anything there. Tried some stuffs. But to make the long story short, the English text of the string is:

Overall progress: %(percent_complete)5.1f%% complete (%(cur_stage)d of %(num_stages)d)

and the current Swahili translation is

Maendeleo yaliyokidhiri:%(percent_complete)5.1%%kamilika%(cur_stage)d ya%(num_stages)d

I noticed that there was a missing f in 5.1% so it should've been 5.1f%.

Having that change will now show the progress bar when downloading Swahili videos.

Member

mrpau-eugene commented Jul 19, 2017

@benjaoming -- @mrpau-eduard explained to me that the progress bar doesn't show when downloading sw videos. So, I checked on updates/base.js first to see if I can do anything there. Tried some stuffs. But to make the long story short, the English text of the string is:

Overall progress: %(percent_complete)5.1f%% complete (%(cur_stage)d of %(num_stages)d)

and the current Swahili translation is

Maendeleo yaliyokidhiri:%(percent_complete)5.1%%kamilika%(cur_stage)d ya%(num_stages)d

I noticed that there was a missing f in 5.1% so it should've been 5.1f%.

Having that change will now show the progress bar when downloading Swahili videos.

@mrpau-eugene mrpau-eugene reopened this Jul 19, 2017

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene Jul 24, 2017

Member

Confirmed to be working after rebuilding the Swahili content pack. Closing this issue again 😄

image

Member

mrpau-eugene commented Jul 24, 2017

Confirmed to be working after rebuilding the Swahili content pack. Closing this issue again 😄

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment