New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrievecontentpack download gives no feedback #5356

Open
radinamatic opened this Issue Dec 7, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@radinamatic
Contributor

radinamatic commented Dec 7, 2016

Summary

For other contentpack issues, see #5336.

System information

  • Operating system: Ubuntu 15.10 64bit
  • Version: 0.17.0b3 pypi
  • Browser: Firefox

Screenshots

It's not possible to download contentpack from network, weather through the UI or with kalite manage retrievecontentpack download. No error in the console or Terminal, but download does not proceed. Link seems correct, for the es.zip Spanish pack in the pantry, but still, nothing happens:

selection_075

@radinamatic radinamatic added this to the 0.17.0 milestone Dec 7, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Dec 7, 2016

Member

I'll clean up the issues regarding how the status of installed content packs is displayed when finalizing the part w/ empty content packs.

Member

benjaoming commented Dec 7, 2016

I'll clean up the issues regarding how the status of installed content packs is displayed when finalizing the part w/ empty content packs.

@benjaoming benjaoming changed the title from Contentpack errors on 0.17.0b3 to retrievecontentpack download freezes (0.17b) Dec 7, 2016

@benjaoming benjaoming changed the title from retrievecontentpack download freezes (0.17b) to retrievecontentpack download gives no feedback (0.17b) Dec 7, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Dec 7, 2016

Member

The actual issue is not that it doesn't work, it's that there's no feedback:

➜  ~ kalite manage retrievecontentpack download es
[INFO] [2016-12-07 21:59:07,376] kalite: Downloading content pack.
[INFO] [2016-12-07 21:59:07,383] kalite: Downloading content pack from http://pantry.learningequality.org/downloads/ka-lite/0.17/content/contentpacks/es.zip
[INFO] [2016-12-07 22:06:33,397] kalite: Moving content files to the right place.
[WARNING] [2016-12-07 22:06:33,492] kalite: No es_icu.js file found in locale_path /home/benjamin/.kalite/locale
[WARNING] [2016-12-07 22:06:33,492] kalite: No es_icu.js file found in locale_path /home/benjamin/.kalite/locale
[INFO] [2016-12-07 22:06:33,492] kalite: Writing i18nized js file to /home/benjamin/.kalite/content/locale/js/i18n/es.js
[INFO] [2016-12-07 22:06:33,729] kalite: Looking for available content items.
[INFO] [2016-12-07 22:06:33,745] kalite: Annotating content for language: es, channel: khan

This may take several minutes depending on system resources...
[INFO] [2016-12-07 22:06:34,265] kalite: Annotation complete for language: es, channel: khan
[INFO] [2016-12-07 22:06:34,265] kalite: Finished processing content pack.

Notice that it took over 7 minutes - it's because Pantry is really slow at the moment.

Member

benjaoming commented Dec 7, 2016

The actual issue is not that it doesn't work, it's that there's no feedback:

➜  ~ kalite manage retrievecontentpack download es
[INFO] [2016-12-07 21:59:07,376] kalite: Downloading content pack.
[INFO] [2016-12-07 21:59:07,383] kalite: Downloading content pack from http://pantry.learningequality.org/downloads/ka-lite/0.17/content/contentpacks/es.zip
[INFO] [2016-12-07 22:06:33,397] kalite: Moving content files to the right place.
[WARNING] [2016-12-07 22:06:33,492] kalite: No es_icu.js file found in locale_path /home/benjamin/.kalite/locale
[WARNING] [2016-12-07 22:06:33,492] kalite: No es_icu.js file found in locale_path /home/benjamin/.kalite/locale
[INFO] [2016-12-07 22:06:33,492] kalite: Writing i18nized js file to /home/benjamin/.kalite/content/locale/js/i18n/es.js
[INFO] [2016-12-07 22:06:33,729] kalite: Looking for available content items.
[INFO] [2016-12-07 22:06:33,745] kalite: Annotating content for language: es, channel: khan

This may take several minutes depending on system resources...
[INFO] [2016-12-07 22:06:34,265] kalite: Annotation complete for language: es, channel: khan
[INFO] [2016-12-07 22:06:34,265] kalite: Finished processing content pack.

Notice that it took over 7 minutes - it's because Pantry is really slow at the moment.

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Dec 7, 2016

Contributor

I left it over half hour and it never moved from second step...
I'll re-try from Windows, and see if the result is similar!

Contributor

radinamatic commented Dec 7, 2016

I left it over half hour and it never moved from second step...
I'll re-try from Windows, and see if the result is similar!

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Dec 7, 2016

Member

Edited the description, let's deal with wrongful display of installed content packs in #5318

Member

benjaoming commented Dec 7, 2016

Edited the description, let's deal with wrongful display of installed content packs in #5318

@radinamatic

This comment has been minimized.

Show comment
Hide comment
@radinamatic

radinamatic Dec 8, 2016

Contributor

It's definitely a network problem, not much we can do about, a part from putting some form of feedback like you suggested. This morning re-try with ES took more than 6 minutes:

osboxes@osboxes:~$ kalite manage retrievecontentpack download es es.zip 
[INFO] [2016-12-08 11:09:21,038] kalite: Cancelling process retrievecontentpack
[INFO] [2016-12-08 11:09:21,115] kalite: Downloading content pack.
[INFO] [2016-12-08 11:09:21,142] kalite: Downloading content pack from http://pantry.learningequality.org/downloads/ka-lite/0.17/content/contentpacks/es.zip
[INFO] [2016-12-08 11:14:53,428] kalite: Moving content files to the right place.
[WARNING] [2016-12-08 11:14:53,634] kalite: No es_icu.js file found in locale_path /home/osboxes/.kalite/locale
[WARNING] [2016-12-08 11:14:53,635] kalite: No es_icu.js file found in locale_path /home/osboxes/.kalite/locale
[INFO] [2016-12-08 11:14:53,635] kalite: Writing i18nized js file to /home/osboxes/.kalite/content/locale/js/i18n/es.js
[INFO] [2016-12-08 11:14:54,448] kalite: Looking for available content items.
[INFO] [2016-12-08 11:14:54,519] kalite: Annotating content for language: es, channel: khan

This may take several minutes depending on system resources...
[INFO] [2016-12-08 11:14:57,112] kalite: Annotation complete for language: es, channel: khan
[INFO] [2016-12-08 11:14:57,113] kalite: Finished processing content pack.
Contributor

radinamatic commented Dec 8, 2016

It's definitely a network problem, not much we can do about, a part from putting some form of feedback like you suggested. This morning re-try with ES took more than 6 minutes:

osboxes@osboxes:~$ kalite manage retrievecontentpack download es es.zip 
[INFO] [2016-12-08 11:09:21,038] kalite: Cancelling process retrievecontentpack
[INFO] [2016-12-08 11:09:21,115] kalite: Downloading content pack.
[INFO] [2016-12-08 11:09:21,142] kalite: Downloading content pack from http://pantry.learningequality.org/downloads/ka-lite/0.17/content/contentpacks/es.zip
[INFO] [2016-12-08 11:14:53,428] kalite: Moving content files to the right place.
[WARNING] [2016-12-08 11:14:53,634] kalite: No es_icu.js file found in locale_path /home/osboxes/.kalite/locale
[WARNING] [2016-12-08 11:14:53,635] kalite: No es_icu.js file found in locale_path /home/osboxes/.kalite/locale
[INFO] [2016-12-08 11:14:53,635] kalite: Writing i18nized js file to /home/osboxes/.kalite/content/locale/js/i18n/es.js
[INFO] [2016-12-08 11:14:54,448] kalite: Looking for available content items.
[INFO] [2016-12-08 11:14:54,519] kalite: Annotating content for language: es, channel: khan

This may take several minutes depending on system resources...
[INFO] [2016-12-08 11:14:57,112] kalite: Annotation complete for language: es, channel: khan
[INFO] [2016-12-08 11:14:57,113] kalite: Finished processing content pack.
@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Dec 12, 2016

Member

I can add that the unpack process should also give proper feedback. On a Raspberry Pi, it's impossible for the user to tell if the process is alive or has stalled. At least indicating the current number of files that have been successfully unpacked would be a start.

Member

benjaoming commented Dec 12, 2016

I can add that the unpack process should also give proper feedback. On a Raspberry Pi, it's impossible for the user to tell if the process is alive or has stalled. At least indicating the current number of files that have been successfully unpacked would be a start.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Dec 12, 2016

Member

...and there's 52229 files in the current English content pack!

Member

benjaoming commented Dec 12, 2016

...and there's 52229 files in the current English content pack!

@benjaoming benjaoming modified the milestones: 0.17.0, 0.17.1 Mar 19, 2017

@benjaoming benjaoming changed the title from retrievecontentpack download gives no feedback (0.17b) to retrievecontentpack download gives no feedback Apr 13, 2017

@benjaoming benjaoming modified the milestones: 0.17.1, 0.17.2 May 5, 2017

@benjaoming benjaoming modified the milestones: 0.17.2, 0.17.3 Jul 9, 2017

@benjaoming benjaoming modified the milestones: 0.17.3, 0.17.4 Aug 30, 2017

@benjaoming benjaoming removed this from the 0.17.3 milestone Aug 30, 2017

@benjaoming benjaoming referenced this issue Nov 23, 2017

Merged

Harden download robustness #5545

3 of 3 tasks complete

@benjaoming benjaoming modified the milestones: 0.17.4, 0.17.5 Dec 20, 2017

@benjaoming benjaoming modified the milestones: 0.17.5, 0.18 Jan 19, 2018

@benjaoming benjaoming removed their assignment Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment