New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About / diagnose page #5452

Closed
benjaoming opened this Issue Apr 20, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@benjaoming
Member

benjaoming commented Apr 20, 2017

Summary

Let's create a very simple page for the Admin login which displays a link in the user drop down, "About".

Page should display:

  • KA Lite version
  • Output from diagnose
  • Statistics from installed content packs

Output from diagnose:

KA LITE VERSION:      0.17.1b1
PYTHON:               2.7.12 (default, Nov 19 2016, 06:48:10) 
                      [GCC 5.4.0 20160609]
PLATFORM:             Linux-4.4.0-72-generic-x86_64-with-Ubuntu-16.04-xenial
SERVER STATUS:        Stopped
INSTALLED IN:         /usr/local/lib/python2.7/site-packages/ka-lite
CONTENT ROOT:         /home/kalite/.kalite/content
CONTENT SIZE:         0 bytes
USER DATABASE:        /home/kalite/.kalite/database/data.sqlite
DEVICE NAME:          testvm
DEVICE ID:            12312321312312312312312312312312
DEVICE REGISTERED:    True
SYNCED:               2017-04-14 23:25:34.138159
SYNC RESULT:          OK
ZONE ID:              12312321312312312312312312312312

@benjaoming benjaoming added this to the 0.17.1 milestone Apr 20, 2017

@benjaoming benjaoming modified the milestones: 0.17.1, 0.17.2 May 5, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 13, 2017

Member

Suggestion to NOT login protect this page:

Normal users should not see links to this page, but it could be valuable for an admin or dev to be able to display the page as debug information regardless of the user logged in.

Member

benjaoming commented Jun 13, 2017

Suggestion to NOT login protect this page:

Normal users should not see links to this page, but it could be valuable for an admin or dev to be able to display the page as debug information regardless of the user logged in.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 16, 2017

Member

We have been discussing that the data from cli.diagnose takes a lot of processing to calculate depending on how many video files it's counting for storage stats.

So we need an AJAX callback and an API endpoint.

Re: DM from @mrpau-eugene

Or if I maybe I didn’t quite understand what you said, maybe you were talking about making an ajax call or something?

Yes, that's what I meant :) The async part is because the browser can render the page and then have Backbone + handlebars logic render the About page.

There's not a super reason to make it async on the backend... the About page won't be displayed by lots of users at the same time so blocking the main HTTP process isn't a problem I think.

Member

benjaoming commented Jun 16, 2017

We have been discussing that the data from cli.diagnose takes a lot of processing to calculate depending on how many video files it's counting for storage stats.

So we need an AJAX callback and an API endpoint.

Re: DM from @mrpau-eugene

Or if I maybe I didn’t quite understand what you said, maybe you were talking about making an ajax call or something?

Yes, that's what I meant :) The async part is because the browser can render the page and then have Backbone + handlebars logic render the About page.

There's not a super reason to make it async on the backend... the About page won't be displayed by lots of users at the same time so blocking the main HTTP process isn't a problem I think.

@mrpau-eugene mrpau-eugene referenced this issue Jun 21, 2017

Merged

About/Diagnose Page #5475

2 of 2 tasks complete
@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jul 4, 2017

Member

Fixed in #5475 :)

Member

benjaoming commented Jul 4, 2017

Fixed in #5475 :)

@benjaoming benjaoming closed this Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment