New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions on by default #5464

Closed
benjaoming opened this Issue May 17, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@benjaoming
Member

benjaoming commented May 17, 2017

Summary

Learners can have difficulties understanding the voice of Sal Khan, especially in countries where English is pronounced substantially different from Khan's North American.

Also, headphones may be low quality, speakers broken, noisy environments, or no sound at all.

In conclusion and by recommendation, we should therefore switch on captions by default when they're available.

System information

  • Operating system: Any
  • Version: 0.17.x
  • Browser: Any

@benjaoming benjaoming added the bug label May 17, 2017

@benjaoming benjaoming added this to the 0.17.2 milestone May 17, 2017

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 18, 2017

Member

Hi @benjaoming. Will it not affect this current issue Dubbed videos should not include subtitles of other languages #5359 if we enable subtitles/captions by default?

Member

mrpau-eugene commented May 18, 2017

Hi @benjaoming. Will it not affect this current issue Dubbed videos should not include subtitles of other languages #5359 if we enable subtitles/captions by default?

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 19, 2017

Member

@benjaoming what should be the behavior when we enable captions by default?

If the default language is set to Spanish es, should it automatically enable the Spanish captions?

Or

Regardless of the default language, we always set the enabled captions to english?

Member

mrpau-eugene commented May 19, 2017

@benjaoming what should be the behavior when we enable captions by default?

If the default language is set to Spanish es, should it automatically enable the Spanish captions?

Or

Regardless of the default language, we always set the enabled captions to english?

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 19, 2017

Member

@mrpau-eugene

Will it not affect this current issue Dubbed videos should not include subtitles of other languages #5359 if we enable subtitles/captions by default?

Great question! The other issue seems to concern specific languages in which the subtitles are substantially different from the dubbed language.

Perhaps the best solution is to make the behaviour configurable through introducing a setting?

from django.conf import settings

AUTO_ENABLED_CAPTIONS = getattr(settings, 'KALITE_AUTO_ENABLED_CAPTIONS', ['en'])

I don't know which module is most suitable to have the setting, but we could certainly introduce it and add a line about it in the documentation.

And because we're only informed that it's relevant to English, we can switch it on only for English by default...

Member

benjaoming commented May 19, 2017

@mrpau-eugene

Will it not affect this current issue Dubbed videos should not include subtitles of other languages #5359 if we enable subtitles/captions by default?

Great question! The other issue seems to concern specific languages in which the subtitles are substantially different from the dubbed language.

Perhaps the best solution is to make the behaviour configurable through introducing a setting?

from django.conf import settings

AUTO_ENABLED_CAPTIONS = getattr(settings, 'KALITE_AUTO_ENABLED_CAPTIONS', ['en'])

I don't know which module is most suitable to have the setting, but we could certainly introduce it and add a line about it in the documentation.

And because we're only informed that it's relevant to English, we can switch it on only for English by default...

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 6, 2017

Member

Pending a test, @radinamatic would you be able to test the current 0.17.x branch to see if captions display as supposed to?

Member

benjaoming commented Jun 6, 2017

Pending a test, @radinamatic would you be able to test the current 0.17.x branch to see if captions display as supposed to?

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jun 19, 2017

Member

Confirmed to be working: #5467 (comment)

Member

benjaoming commented Jun 19, 2017

Confirmed to be working: #5467 (comment)

@benjaoming benjaoming closed this Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment